From: Rick Jones <rick.jones2@hp.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Driver writer hints (was [PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls)
Date: Fri, 10 Aug 2007 14:01:23 -0700 [thread overview]
Message-ID: <46BCD223.6020304@hp.com> (raw)
In-Reply-To: <46BCCE57.1060802@garzik.org>
> If we are getting (retrieving) flags:
>
> 3) Userland issues ETHTOOL_GPFLAGS, to obtain a 32-bit bitmap
>
> 4) Userland prints out a tag returned from ETHTOOL_GSTRINGS
> for each bit set to one in the bitmap. If a bit is set,
> but there is no string to describe it, that bit is ignored.
> (i.e. a list of 5 strings is returned, but bit 24 is set)
Is that to enable "hidden" bits? If not I'd think that emitting some
sort of "UNKNOWN_FLAG" might help flush-out little oopses like
forgetting a string.
rick jones
next prev parent reply other threads:[~2007-08-10 21:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 20:24 [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls Jeff Garzik
2007-08-10 20:25 ` [PATCH 2/4] ethtool: introduce get_sset_count Jeff Garzik
2007-08-10 20:26 ` [PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls Jeff Garzik
2007-08-10 20:45 ` Driver writer hints (was [PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls) Jeff Garzik
2007-08-10 21:01 ` Rick Jones [this message]
2007-08-10 21:08 ` Jeff Garzik
2007-08-10 20:26 ` [PATCH 4/4] ethtool: internal simplification Jeff Garzik
2007-08-10 20:56 ` [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls Jeff Garzik
2007-08-15 23:05 ` David Miller
2007-08-10 21:02 ` Jeff Garzik
2007-08-10 21:11 ` Ben Greear
2007-08-10 22:10 ` David Miller
2007-08-10 22:40 ` Ben Greear
2007-08-10 22:46 ` David Miller
2007-08-10 23:15 ` Rick Jones
2007-08-14 20:38 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BCD223.6020304@hp.com \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).