From: Michael Trimarchi <trimarchi@gandalf.sssup.it>
To: Michael Buesch <mb@bu3sch.de>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: dm9000: add set_mac_address() v2
Date: Mon, 13 Aug 2007 00:45:17 +0200 [thread overview]
Message-ID: <46BF8D7D.5070105@gandalf.sssup.it> (raw)
In-Reply-To: <200708130026.07221.mb@bu3sch.de>
>> + return -EBUSY;
>> +
>> + memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
>> +
>> + for (i = 0; i < 3; i++)
>> + write_srom_word(db, i,
>> + cpu_to_le16(((u16 *) (addr->sa_data))[i]));
>>
>
> Nope.
>
> write_srom_word(db, i, le16_to_cpu(((__le16 *) (addr->sa_data))[i]));
>
>
Are you sure? I don't know how the dm9000 reads the eeprom back.
regards
Michael
next prev parent reply other threads:[~2007-08-12 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 19:27 dm9000: add set_mac_address() Michael Trimarchi
2007-08-12 21:38 ` Michael Buesch
2007-08-12 21:20 ` dm9000: add set_mac_address() v2 michael trimarchi
2007-08-12 22:26 ` Michael Buesch
2007-08-12 22:45 ` Michael Trimarchi [this message]
2007-08-12 22:58 ` Michael Buesch
2007-08-12 21:45 ` dm9000: add set_mac_address() Michael Buesch
2007-08-12 20:54 ` michael trimarchi
2007-08-12 23:08 ` Jeff Garzik
2007-08-13 7:24 ` Michael Trimarchi
2007-08-14 10:10 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BF8D7D.5070105@gandalf.sssup.it \
--to=trimarchi@gandalf.sssup.it \
--cc=jgarzik@pobox.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).