From: Jiri Slaby <jirislaby@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
jbenc@suse.cz, flamingice@sourmilk.net, jeff@garzik.org
Subject: Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data
Date: Mon, 13 Aug 2007 21:59:19 +0200 [thread overview]
Message-ID: <46C0B817.50707@gmail.com> (raw)
In-Reply-To: <1187009029.27916.107.camel@johannes.berg>
Johannes Berg napsal(a):
> On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote:
>
>> + if (control->flags & IEEE80211_TXCTL_REQ_TX_STATUS)
>> + pkt_data->flags |= IEEE80211_TXPD_REQ_TX_STATUS;
>> + if (control->flags & IEEE80211_TXCTL_DO_NOT_ENCRYPT)
>> + pkt_data->flags |= IEEE80211_TXPD_DO_NOT_ENCRYPT;
>> + if (control->flags & IEEE80211_TXCTL_REQUEUE)
>> + pkt_data->flags |= IEEE80211_TXPD_REQUEUE;
>> + if (control->type == IEEE80211_IF_TYPE_MGMT)
>> + pkt_data->flags |= IEEE80211_TXPD_MGMT_IFACE;
>
> This looks weird. Can't we just use the same flags?
I don't think, that it must be subset one of each another in the future. (This
is why I created yet another bits defined).
Do we still want the same flags?
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University
prev parent reply other threads:[~2007-08-13 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 13:08 [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data Jiri Slaby
2007-08-12 13:08 ` [PATCH 2/4] Net: mac80211, remove bitfields from struct ieee80211_txrx_data Jiri Slaby
[not found] ` <2653412025907217317-2EuRcrBQ8V0@public.gmane.org>
2007-08-13 12:44 ` Johannes Berg
[not found] ` <1187009078.27916.109.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-08-13 20:01 ` Jiri Slaby
2007-08-12 13:08 ` [PATCH 3/4] Net: mac80211, remove bitfields from struct ieee80211_if_sta Jiri Slaby
[not found] ` <32694265142306417777-2EuRcrBQ8V0@public.gmane.org>
2007-08-12 13:09 ` [PATCH 4/4] Net: mac80211, remove bitfields from struct ieee80211_sub_if_data Jiri Slaby
2007-08-13 12:43 ` [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data Johannes Berg
2007-08-13 19:59 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C0B817.50707@gmail.com \
--to=jirislaby@gmail.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=jeff@garzik.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).