From: Jeff Garzik <jeff@garzik.org>
To: ram.vepa@neterion.com
Cc: netdev@vger.kernel.org, support@neterion.com
Subject: Re: [PATCH 2.6.24]S2io: Enhance device error/alarm handling
Date: Tue, 14 Aug 2007 01:04:25 -0400 [thread overview]
Message-ID: <46C137D9.7050504@garzik.org> (raw)
In-Reply-To: <1186542917.1997.17.camel@flash>
Ramkrishna Vepa wrote:
> - Added support to poll for entire set of device errors and alarms.
> - Optimized interrupt routine fast path.
> - Removed the unused variable, intr_type, in device private structure.
>
> Signed-off-by: Santosh Rastapur <santosh.rastapur@neterion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
please split this patch up into multiple patches.
In general it's OK to combine several small, minor changes together, but
this patch was pretty big. at that point, you need to start looking
into splitting up patches into separate logical changes (intr_type clean
in its own patch, irq handler optimization in its own patch, etc.).
More patches means that each patch is smaller, making it easier to
review. It also means that automated tools such as git-bisect can
easily identify which change created a regression, should one appear.
prev parent reply other threads:[~2007-08-14 5:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 3:15 [PATCH 2.6.24]S2io: Enhance device error/alarm handling Ramkrishna Vepa
2007-08-14 5:04 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C137D9.7050504@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=ram.vepa@neterion.com \
--cc=support@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).