* [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment
@ 2007-08-08 11:20 Mariusz Kozlowski
2007-08-08 20:14 ` Arjan van de Ven
2007-08-14 5:05 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Mariusz Kozlowski @ 2007-08-08 11:20 UTC (permalink / raw)
To: Jeff Garzik, Arjan van de Ven; +Cc: netdev, linux-kernel
Hello,
Unpatched version does sth like this:
dev = alloc_etherdev(...
private = netdev_priv(dev);
...
dev->priv = private;
which doesn't make much sense (does it?) because this is done in
alloc_netdev() already.
struct net_device *alloc_netdev(...
{
...
if (sizeof_priv)
dev->priv = netdev_priv(dev);
This patch removes superfluous code.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
drivers/net/tulip/xircom_cb.c | 32853 -> 32831 (-22 bytes)
drivers/net/tulip/xircom_cb.o | 123984 -> 123984 (0 bytes)
drivers/net/tulip/xircom_cb.c | 1 -
1 file changed, 1 deletion(-)
--- linux-2.6.23-rc1-mm2-a/drivers/net/tulip/xircom_cb.c 2007-08-01 08:43:46.000000000 +0200
+++ linux-2.6.23-rc1-mm2-b/drivers/net/tulip/xircom_cb.c 2007-08-08 11:06:22.000000000 +0200
@@ -271,7 +271,6 @@ static int __devinit xircom_probe(struct
dev->hard_start_xmit = &xircom_start_xmit;
dev->stop = &xircom_close;
dev->get_stats = &xircom_get_stats;
- dev->priv = private;
#ifdef CONFIG_NET_POLL_CONTROLLER
dev->poll_controller = &xircom_poll_controller;
#endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment
2007-08-08 11:20 [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment Mariusz Kozlowski
@ 2007-08-08 20:14 ` Arjan van de Ven
2007-08-14 5:05 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Arjan van de Ven @ 2007-08-08 20:14 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: Jeff Garzik, netdev, linux-kernel
On Wed, 2007-08-08 at 13:20 +0200, Mariusz Kozlowski wrote:
> Hello,
>
> Unpatched version does sth like this:
>
> dev = alloc_etherdev(...
> private = netdev_priv(dev);
> ...
> dev->priv = private;
>
> which doesn't make much sense (does it?) because this is done in
> alloc_netdev() already.
Looks good
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment
2007-08-08 11:20 [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment Mariusz Kozlowski
2007-08-08 20:14 ` Arjan van de Ven
@ 2007-08-14 5:05 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-08-14 5:05 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: Arjan van de Ven, netdev, linux-kernel
Mariusz Kozlowski wrote:
> Hello,
>
> Unpatched version does sth like this:
>
> dev = alloc_etherdev(...
> private = netdev_priv(dev);
> ...
> dev->priv = private;
>
> which doesn't make much sense (does it?) because this is done in
> alloc_netdev() already.
>
> struct net_device *alloc_netdev(...
> {
> ...
> if (sizeof_priv)
> dev->priv = netdev_priv(dev);
>
> This patch removes superfluous code.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-14 5:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-08 11:20 [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment Mariusz Kozlowski
2007-08-08 20:14 ` Arjan van de Ven
2007-08-14 5:05 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).