netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/13] cxgb3 - Update rx coalescing length
@ 2007-08-11  6:29 Divy Le Ray
  2007-08-14  5:41 ` Jeff Garzik
  0 siblings, 1 reply; 3+ messages in thread
From: Divy Le Ray @ 2007-08-11  6:29 UTC (permalink / raw)
  To: jeff; +Cc: netdev, linux-kernel, swise

From: Divy Le Ray <divy@chelsio.com>

Set max Rx coalescing length to 12288

Signed-off-by: Divy Le Ray <divy@chelsio.com>
---

 drivers/net/cxgb3/common.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
index c46c249..55922ed 100644
--- a/drivers/net/cxgb3/common.h
+++ b/drivers/net/cxgb3/common.h
@@ -104,7 +104,7 @@ enum {
 	PROTO_SRAM_LINES = 128, /* size of TP sram */
 };
 
-#define MAX_RX_COALESCING_LEN 16224U
+#define MAX_RX_COALESCING_LEN 12288U
 
 enum {
 	PAUSE_RX = 1 << 0,

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/13] cxgb3 - Update rx coalescing length
  2007-08-11  6:29 [PATCH 2/13] cxgb3 - Update rx coalescing length Divy Le Ray
@ 2007-08-14  5:41 ` Jeff Garzik
  2007-08-14 23:22   ` Divy Le Ray
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-08-14  5:41 UTC (permalink / raw)
  To: Divy Le Ray; +Cc: netdev, linux-kernel, swise

Divy Le Ray wrote:
> From: Divy Le Ray <divy@chelsio.com>
> 
> Set max Rx coalescing length to 12288
> 
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
> ---
> 
>  drivers/net/cxgb3/common.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
> index c46c249..55922ed 100644
> --- a/drivers/net/cxgb3/common.h
> +++ b/drivers/net/cxgb3/common.h
> @@ -104,7 +104,7 @@ enum {
>  	PROTO_SRAM_LINES = 128, /* size of TP sram */
>  };
>  
> -#define MAX_RX_COALESCING_LEN 16224U
> +#define MAX_RX_COALESCING_LEN 12288U

neither the patch nor description explains -why-



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/13] cxgb3 - Update rx coalescing length
  2007-08-14  5:41 ` Jeff Garzik
@ 2007-08-14 23:22   ` Divy Le Ray
  0 siblings, 0 replies; 3+ messages in thread
From: Divy Le Ray @ 2007-08-14 23:22 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev, linux-kernel, Steve Wise

Jeff Garzik wrote:
>
> Divy Le Ray wrote:
> > From: Divy Le Ray <divy@chelsio.com>
> >
> > Set max Rx coalescing length to 12288
> >
> > Signed-off-by: Divy Le Ray <divy@chelsio.com>
> > ---
> >
> >  drivers/net/cxgb3/common.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
> > index c46c249..55922ed 100644
> > --- a/drivers/net/cxgb3/common.h
> > +++ b/drivers/net/cxgb3/common.h
> > @@ -104,7 +104,7 @@ enum {
> >       PROTO_SRAM_LINES = 128, /* size of TP sram */
> >  };
> > 
> > -#define MAX_RX_COALESCING_LEN 16224U
> > +#define MAX_RX_COALESCING_LEN 12288U
>
> neither the patch nor description explains -why-
>

We're seeing back pressure from PCIe with large bursts, this patch 
allows to cut down on the burst size.

Divy


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-08-14 23:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-11  6:29 [PATCH 2/13] cxgb3 - Update rx coalescing length Divy Le Ray
2007-08-14  5:41 ` Jeff Garzik
2007-08-14 23:22   ` Divy Le Ray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).