* [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet
@ 2007-08-10 21:05 akpm
2007-08-14 5:30 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: akpm @ 2007-08-10 21:05 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, peter.oruba, brice, rolandd, shemminger
From: "Peter Oruba" <peter.oruba@amd.com>
These driver changes incorporate the proposed PCI-X / PCI-Express read byte
count interface. Reading and setting those valuse doesn't take place
"manually", instead wrapping functions are called to allow quirks for some
PCI bridges.
Signed-off by: Peter Oruba <peter.oruba@amd.com>
Based on work by Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Roland Dreier <rolandd@cisco.com>
Cc: Brice Goglin <brice@myri.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/myri10ge/myri10ge.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet drivers/net/myri10ge/myri10ge.c
--- a/drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
+++ a/drivers/net/myri10ge/myri10ge.c
@@ -2884,8 +2884,7 @@ static int myri10ge_probe(struct pci_dev
status);
goto abort_with_netdev;
}
- val = (val & ~PCI_EXP_DEVCTL_READRQ) | (5 << 12);
- status = pci_write_config_word(pdev, cap + PCI_EXP_DEVCTL, val);
+ status = pcie_set_readrq(pdev, 4096);
if (status != 0) {
dev_err(&pdev->dev, "Error %d writing PCI_EXP_DEVCTL\n",
status);
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet
2007-08-10 21:05 [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet akpm
@ 2007-08-14 5:30 ` Jeff Garzik
2007-08-14 5:49 ` Brice Goglin
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-08-14 5:30 UTC (permalink / raw)
To: akpm, brice; +Cc: netdev, peter.oruba, rolandd, shemminger
akpm@linux-foundation.org wrote:
> From: "Peter Oruba" <peter.oruba@amd.com>
>
> These driver changes incorporate the proposed PCI-X / PCI-Express read byte
> count interface. Reading and setting those valuse doesn't take place
> "manually", instead wrapping functions are called to allow quirks for some
> PCI bridges.
>
> Signed-off by: Peter Oruba <peter.oruba@amd.com>
> Based on work by Stephen Hemminger <shemminger@linux-foundation.org>
> Cc: Roland Dreier <rolandd@cisco.com>
> Cc: Brice Goglin <brice@myri.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/myri10ge/myri10ge.c | 3 +--
> 1 files changed, 1 insertion(+), 2 deletions(-)
>
> diff -puN drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet drivers/net/myri10ge/myri10ge.c
> --- a/drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
> +++ a/drivers/net/myri10ge/myri10ge.c
> @@ -2884,8 +2884,7 @@ static int myri10ge_probe(struct pci_dev
> status);
> goto abort_with_netdev;
> }
> - val = (val & ~PCI_EXP_DEVCTL_READRQ) | (5 << 12);
> - status = pci_write_config_word(pdev, cap + PCI_EXP_DEVCTL, val);
> + status = pcie_set_readrq(pdev, 4096);
I presume Brice will resend this one to me, next time he pushes...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet
2007-08-14 5:30 ` Jeff Garzik
@ 2007-08-14 5:49 ` Brice Goglin
0 siblings, 0 replies; 3+ messages in thread
From: Brice Goglin @ 2007-08-14 5:49 UTC (permalink / raw)
To: Jeff Garzik; +Cc: akpm, netdev, peter.oruba, rolandd, shemminger
Jeff Garzik wrote:
> akpm@linux-foundation.org wrote:
>> From: "Peter Oruba" <peter.oruba@amd.com>
>>
>> These driver changes incorporate the proposed PCI-X / PCI-Express
>> read byte
>> count interface. Reading and setting those valuse doesn't take place
>> "manually", instead wrapping functions are called to allow quirks for
>> some
>> PCI bridges.
>>
>
> I presume Brice will resend this one to me, next time he pushes...
Ok, I'll take care of it.
Brice
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-14 5:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-10 21:05 [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet akpm
2007-08-14 5:30 ` Jeff Garzik
2007-08-14 5:49 ` Brice Goglin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).