* [PATCH] netfilter : xt_u32 bug correction
@ 2007-08-14 12:17 Eric Dumazet
2007-08-14 12:20 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2007-08-14 12:17 UTC (permalink / raw)
To: kaber@trash.net, David Miller; +Cc: netdev@vger.kernel.org, jengelh
Hi all
This applies to net-2.6 (so should be forwared to Linus for 2.6.23 inclusion ?)
Thank you
[PATCH] netfilter : xt_u32 bug correction
An extraneous ";" makes xt_u32 match useless
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] netfilter : xt_u32 bug correction
2007-08-14 12:17 [PATCH] netfilter : xt_u32 bug correction Eric Dumazet
@ 2007-08-14 12:20 ` Eric Dumazet
2007-08-14 16:34 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2007-08-14 12:20 UTC (permalink / raw)
To: kaber@trash.net, David Miller; +Cc: netdev@vger.kernel.org, jengelh
Hi all
This applies to net-2.6 (so should be forwared to Linus for 2.6.23 inclusion ?)
Sorry for the first mail without attachment.
Thank you
[PATCH] netfilter : xt_u32 bug correction
An extraneous ";" makes xt_u32 match useless
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
diff --git a/net/netfilter/xt_u32.c b/net/netfilter/xt_u32.c
index 04b677a..89b2d5c 100644
--- a/net/netfilter/xt_u32.c
+++ b/net/netfilter/xt_u32.c
@@ -35,7 +35,7 @@ static bool u32_match_it(const struct xt_u32 *data,
at = 0;
pos = ct->location[0].number;
- if (skb->len < 4 || pos > skb->len - 4);
+ if (skb->len < 4 || pos > skb->len - 4)
return false;
ret = skb_copy_bits(skb, pos, &val, sizeof(val));
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-14 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-14 12:17 [PATCH] netfilter : xt_u32 bug correction Eric Dumazet
2007-08-14 12:20 ` Eric Dumazet
2007-08-14 16:34 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox