From: Divy Le Ray <divy@chelsio.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Steve Wise <swise@opengridcomputing.com>
Subject: Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx
Date: Tue, 14 Aug 2007 16:25:32 -0700 [thread overview]
Message-ID: <46C239EC.7000505@chelsio.com> (raw)
In-Reply-To: <46C14106.4080604@garzik.org>
Jeff Garzik wrote:
>
> Divy Le Ray wrote:
> > From: Divy Le Ray <divy@chelsio.com>
> >
> > Send small TX_DATA work requests as immediate data even when
> > there are fragments.
> >
> > Signed-off-by: Divy Le Ray <divy@chelsio.com>
> > ---
> >
> > drivers/net/cxgb3/sge.c | 17 +++++++++++------
> > 1 files changed, 11 insertions(+), 6 deletions(-)
>
> needs additional explanation. don't just describe the new post-change
> behavior, describe why this change is needed.
>
>
It's an optimization avoiding doing multiple DMAs for small fragmented
packets.
The driver already implements this optimization for small contiguous
packets.
Divy
prev parent reply other threads:[~2007-08-14 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-11 6:29 [PATCH 4/13] cxgb3 - use immediate data for offload Tx Divy Le Ray
2007-08-14 5:43 ` Jeff Garzik
2007-08-14 23:25 ` Divy Le Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C239EC.7000505@chelsio.com \
--to=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).