* [PATCH -mm] drivers/net/e1000e/netdev.c warning fix
@ 2007-08-22 12:51 Michal Piotrowski
2007-08-22 14:40 ` Kok, Auke
0 siblings, 1 reply; 2+ messages in thread
From: Michal Piotrowski @ 2007-08-22 12:51 UTC (permalink / raw)
To: Andrew Morton, Netdev, Linux NICS, e1000-devel
Hi,
This patch fixes the following compilation warning
drivers/net/e1000e/netdev.c: In function ‘e1000_setup_rctl’:
drivers/net/e1000e/netdev.c:1963: warning: unused variable ‘pages’
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
--- linux-mm-clean/drivers/net/e1000e/netdev.c 2007-08-22 12:20:31.000000000 +0200
+++ linux-work/drivers/net/e1000e/netdev.c 2007-08-22 14:44:58.000000000 +0200
@@ -1960,7 +1960,10 @@ static void e1000_setup_rctl(struct e100
struct e1000_hw *hw = &adapter->hw;
u32 rctl, rfctl;
u32 psrctl = 0;
+
+#ifndef CONFIG_E1000_DISABLE_PACKET_SPLIT
u32 pages = 0;
+#endif
/* Program MC offset vector base */
rctl = er32(RCTL);
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -mm] drivers/net/e1000e/netdev.c warning fix
2007-08-22 12:51 [PATCH -mm] drivers/net/e1000e/netdev.c warning fix Michal Piotrowski
@ 2007-08-22 14:40 ` Kok, Auke
0 siblings, 0 replies; 2+ messages in thread
From: Kok, Auke @ 2007-08-22 14:40 UTC (permalink / raw)
To: Michal Piotrowski; +Cc: e1000-devel, Netdev, Andrew Morton, Linux NICS
Michal Piotrowski wrote:
> Hi,
>
> This patch fixes the following compilation warning
>
> drivers/net/e1000e/netdev.c: In function ‘e1000_setup_rctl’:
> drivers/net/e1000e/netdev.c:1963: warning: unused variable ‘pages’
>
> Regards,
> Michal
>
also exposes a symbol issue. I think I want to remove this #ifdef
CONFIG_E1000_DISABLE_PACKET_SPLIT from this driver alltogether...
Auke
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-22 14:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-22 12:51 [PATCH -mm] drivers/net/e1000e/netdev.c warning fix Michal Piotrowski
2007-08-22 14:40 ` Kok, Auke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).