From: "Denis V. Lunev" <dlunev@gmail.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: "Denis V. Lunev" <dlunev@gmail.com>,
containers@lists.osdl.org, netdev@vger.kernel.org,
davem@davemloft.net
Subject: Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device
Date: Sat, 25 Aug 2007 01:24:29 +0400 [thread overview]
Message-ID: <46CF4C8D.9010709@gmail.com> (raw)
In-Reply-To: <20070824104301.2f4ff34e@localhost>
no, and this is important. Loopback is initialized in fs_initcall which
is called sufficiently before module_init.
I have checked the code and do not see initialization order mistakes
right now. But, from now on, maintainer should pay attention for this
unfortunate consequence :(
Regards,
Den
Stephen Hemminger wrote:
> On Fri, 24 Aug 2007 19:55:47 +0400
> "Denis V. Lunev" <dlunev@gmail.com> wrote:
>
>> dlezcano@fr.ibm.com wrote:
>>> From: Daniel Lezcano <dlezcano@fr.ibm.com>
>>>
>>> Doing this makes loopback.c a better example of how to do a
>>> simple network device, and it removes the special case
>>> single static allocation of a struct net_device, hopefully
>>> making maintenance easier.
>>>
>>> Applies against net-2.6.24
>>>
>>> Tested on i386, x86_64
>>> Compiled on ia64, sparc
>> I think that a small note, that initialization order is changed will be
>> good to record. After this, loopback MUST be allocated before any other
>> networking subsystem initialization. And this is an important change.
>>
>> Regards,
>> Den
>
> Yes, this code would break when other drivers are directly linked
> in.
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
>
> _______________________________________________
> Devel mailing list
> Devel@openvz.org
> https://openvz.org/mailman/listinfo/devel
>
next prev parent reply other threads:[~2007-08-24 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 15:36 [PATCH 1/1] Dynamically allocate the loopback device dlezcano
2007-08-24 15:55 ` [Devel] " Denis V. Lunev
2007-08-24 16:44 ` Daniel Lezcano
[not found] ` <46CEFF83.3040003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-08-24 17:43 ` Stephen Hemminger
2007-08-24 21:24 ` Denis V. Lunev [this message]
2007-08-27 12:12 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CF4C8D.9010709@gmail.com \
--to=dlunev@gmail.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).