From: Jeff Garzik <jeff@garzik.org>
To: Laurent Pinchart <laurentp@cse-semaphore.com>
Cc: netdev@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH 1/2] [DM9000] Added support for big-endian hosts
Date: Sat, 25 Aug 2007 00:31:58 -0400 [thread overview]
Message-ID: <46CFB0BE.4030301@garzik.org> (raw)
In-Reply-To: <200708161015.35337.laurentp@cse-semaphore.com>
Laurent Pinchart wrote:
> This patch splits the receive status in 8bit wide fields and convert the
> packet length from little endian to CPU byte order.
>
> Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> ---
> drivers/net/dm9000.c | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index c3de81b..a424810 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -894,7 +894,8 @@ dm9000_timer(unsigned long data)
> }
>
> struct dm9000_rxhdr {
> - u16 RxStatus;
> + u8 RxPktReady;
> + u8 RxStatus;
> u16 RxLen;
> } __attribute__((__packed__));
why does this not need endian conversions as well?
Jeff
next prev parent reply other threads:[~2007-08-25 4:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 8:15 [PATCH 1/2] [DM9000] Added support for big-endian hosts Laurent Pinchart
2007-08-16 17:00 ` Ben Dooks
2007-08-25 4:31 ` Jeff Garzik [this message]
2007-08-27 7:51 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CFB0BE.4030301@garzik.org \
--to=jeff@garzik.org \
--cc=ben-linux@fluff.org \
--cc=laurentp@cse-semaphore.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).