From: Jeff Garzik <jeff@garzik.org>
To: Domen Puncer <domen.puncer@telargo.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] phy layer: fix genphy_setup_forced (don't reset)
Date: Sat, 25 Aug 2007 00:40:43 -0400 [thread overview]
Message-ID: <46CFB2CB.1040400@garzik.org> (raw)
In-Reply-To: <20070817065445.GH13994@moe.telargo.com>
Domen Puncer wrote:
> Writing BMCR_RESET bit will reset MII_BMCR to default values. This is
> clearly not what we want.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
>
> ---
> drivers/net/phy/phy_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: work-powerpc.git/drivers/net/phy/phy_device.c
> ===================================================================
> --- work-powerpc.git.orig/drivers/net/phy/phy_device.c
> +++ work-powerpc.git/drivers/net/phy/phy_device.c
> @@ -364,7 +364,7 @@ EXPORT_SYMBOL(genphy_config_advert);
> */
> int genphy_setup_forced(struct phy_device *phydev)
> {
> - int ctl = BMCR_RESET;
> + int ctl = 0;
>
> phydev->pause = phydev->asym_pause = 0;
applied
prev parent reply other threads:[~2007-08-25 4:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 6:54 [PATCH] phy layer: fix genphy_setup_forced (don't reset) Domen Puncer
2007-08-20 19:43 ` Andy Fleming
2007-08-25 4:40 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CFB2CB.1040400@garzik.org \
--to=jeff@garzik.org \
--cc=domen.puncer@telargo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).