* [PATCH] phy layer: fix genphy_setup_forced (don't reset)
@ 2007-08-17 6:54 Domen Puncer
2007-08-20 19:43 ` Andy Fleming
2007-08-25 4:40 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Domen Puncer @ 2007-08-17 6:54 UTC (permalink / raw)
To: jeff; +Cc: netdev
Writing BMCR_RESET bit will reset MII_BMCR to default values. This is
clearly not what we want.
Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
---
drivers/net/phy/phy_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: work-powerpc.git/drivers/net/phy/phy_device.c
===================================================================
--- work-powerpc.git.orig/drivers/net/phy/phy_device.c
+++ work-powerpc.git/drivers/net/phy/phy_device.c
@@ -364,7 +364,7 @@ EXPORT_SYMBOL(genphy_config_advert);
*/
int genphy_setup_forced(struct phy_device *phydev)
{
- int ctl = BMCR_RESET;
+ int ctl = 0;
phydev->pause = phydev->asym_pause = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy layer: fix genphy_setup_forced (don't reset)
2007-08-17 6:54 [PATCH] phy layer: fix genphy_setup_forced (don't reset) Domen Puncer
@ 2007-08-20 19:43 ` Andy Fleming
2007-08-25 4:40 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Andy Fleming @ 2007-08-20 19:43 UTC (permalink / raw)
To: Domen Puncer; +Cc: jeff, netdev
On Aug 17, 2007, at 01:54, Domen Puncer wrote:
> Writing BMCR_RESET bit will reset MII_BMCR to default values. This is
> clearly not what we want.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
Acked-by: Andy Fleming <afleming@freescale.com>
I could have sworn there was a patch that did this, already, but it
must have lost steam somewhere.
Andy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy layer: fix genphy_setup_forced (don't reset)
2007-08-17 6:54 [PATCH] phy layer: fix genphy_setup_forced (don't reset) Domen Puncer
2007-08-20 19:43 ` Andy Fleming
@ 2007-08-25 4:40 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-08-25 4:40 UTC (permalink / raw)
To: Domen Puncer; +Cc: netdev
Domen Puncer wrote:
> Writing BMCR_RESET bit will reset MII_BMCR to default values. This is
> clearly not what we want.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
>
> ---
> drivers/net/phy/phy_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: work-powerpc.git/drivers/net/phy/phy_device.c
> ===================================================================
> --- work-powerpc.git.orig/drivers/net/phy/phy_device.c
> +++ work-powerpc.git/drivers/net/phy/phy_device.c
> @@ -364,7 +364,7 @@ EXPORT_SYMBOL(genphy_config_advert);
> */
> int genphy_setup_forced(struct phy_device *phydev)
> {
> - int ctl = BMCR_RESET;
> + int ctl = 0;
>
> phydev->pause = phydev->asym_pause = 0;
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-25 4:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-17 6:54 [PATCH] phy layer: fix genphy_setup_forced (don't reset) Domen Puncer
2007-08-20 19:43 ` Andy Fleming
2007-08-25 4:40 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).