netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Use task_pid_nr() in ip_vs_sync.c
@ 2007-08-29 13:30 Pavel Emelyanov
  2007-08-29 21:50 ` sukadev
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2007-08-29 13:30 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Linux Containers, Linux Netdev List, Oleg Nesterov,
	Linux Kernel Mailing List

The sync_master_pid and sync_backup_pid are set in set_sync_pid()
and are used later for set/not-set checks and in printk. So it
is safe to use the global pid value in this case.

Signed-off-by: Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>

---

diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
index 959c08d..d0798a5 100644
--- a/net/ipv4/ipvs/ip_vs_sync.c
+++ b/net/ipv4/ipvs/ip_vs_sync.c
@@ -794,7 +794,7 @@ static int sync_thread(void *startup)
 
 	add_wait_queue(&sync_wait, &wait);
 
-	set_sync_pid(state, current->pid);
+	set_sync_pid(state, task_pid_nr(current));
 	complete(tinfo->startup);
 
 	/*

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Use task_pid_nr() in ip_vs_sync.c
  2007-08-29 13:30 [PATCH] Use task_pid_nr() in ip_vs_sync.c Pavel Emelyanov
@ 2007-08-29 21:50 ` sukadev
  0 siblings, 0 replies; 2+ messages in thread
From: sukadev @ 2007-08-29 21:50 UTC (permalink / raw)
  To: Pavel Emelyanov
  Cc: Andrew Morton, Oleg Nesterov, Linux Containers,
	Linux Kernel Mailing List, Linux Netdev List

Pavel Emelianov [xemul@openvz.org] wrote:
| The sync_master_pid and sync_backup_pid are set in set_sync_pid()
| and are used later for set/not-set checks and in printk. So it
| is safe to use the global pid value in this case.
| 
| Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Acked-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
| 
| ---
| 
| diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
| index 959c08d..d0798a5 100644
| --- a/net/ipv4/ipvs/ip_vs_sync.c
| +++ b/net/ipv4/ipvs/ip_vs_sync.c
| @@ -794,7 +794,7 @@ static int sync_thread(void *startup)
| 
| 	add_wait_queue(&sync_wait, &wait);
| 
| -	set_sync_pid(state, current->pid);
| +	set_sync_pid(state, task_pid_nr(current));
| 	complete(tinfo->startup);
| 
| 	/*

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-29 21:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-29 13:30 [PATCH] Use task_pid_nr() in ip_vs_sync.c Pavel Emelyanov
2007-08-29 21:50 ` sukadev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).