netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <dlezcano@meiosys.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	David Miller <davem@davemloft.net>,
	dlezcano@fr.ibm.com, netdev@vger.kernel.org, ralf@linux-mips.org,
	hch@infradead.org
Subject: Re: [patch 0/1][RFC] add a private field to the sock structure
Date: Wed, 29 Aug 2007 23:15:31 +0200	[thread overview]
Message-ID: <46D5E1F3.4020009@meiosys.com> (raw)
In-Reply-To: <20070829191831.GA16184@ghostprotocols.net>

Arnaldo Carvalho de Melo wrote:
> Em Wed, Aug 29, 2007 at 11:23:16AM -0700, David Miller escreveu:
>> From: dlezcano@fr.ibm.com
>> Date: Wed, 29 Aug 2007 18:41:14 +0200
>>
>>> When a socket is created it is sometime useful to store a specific information
>>> for this socket.
>>>  
>>> This information can be for examples: 
>>> 	* a creation time
>>> 	* a pid
>>> 	* a uid/gid
>>> 	* a container identifier
>>> 	* a pointer to a more specific structure
>>> 	* ...
>>>
>>> The following patch is a proposition to add a private anonymous pointer
>>> field to the common part of the sock structure.
>> We got rid of the private field a long time ago because not only
>> is it not needed, it tends to get abused.
> 
> Nah, it still there, sk_protinfo, its just ax25 that uses it
> (nudge(Ralf)). How do we state that a struct field is deprecated and
> will be removed soon(tm)?
> 
> There is another, sk_user_data, that is used only by the rpc, pppol2tp,
> iscsi, ncpfs, smbfs and dlm guys, see? We need a deprecate flag for
> sk_protinfo, if not people will use it! :-)

Thank you for your feedbacks. I will play with the sk_user_data.

Is there a chance to have this field in the timewait sockets ? :)

Regards
	--Daniel

  reply	other threads:[~2007-08-29 21:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29 16:41 [patch 0/1][RFC] add a private field to the sock structure dlezcano
2007-08-29 16:41 ` [patch 1/1][RFC] " dlezcano
2007-08-29 18:09   ` Christoph Hellwig
2007-08-29 18:23 ` [patch 0/1][RFC] " David Miller
2007-08-29 19:18   ` Arnaldo Carvalho de Melo
2007-08-29 21:15     ` Daniel Lezcano [this message]
2007-08-31  5:40     ` David Miller
2007-08-31 11:26       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D5E1F3.4020009@meiosys.com \
    --to=dlezcano@meiosys.com \
    --cc=acme@ghostprotocols.net \
    --cc=davem@davemloft.net \
    --cc=dlezcano@fr.ibm.com \
    --cc=hch@infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).