netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* bonding xmit overwrite skb->priority
@ 2007-08-30 10:06 Francesco Dolcini
  0 siblings, 0 replies; only message in thread
From: Francesco Dolcini @ 2007-08-30 10:06 UTC (permalink / raw)
  To: netdev

Bonding code set skb->priority=1 before trasmitting frame to the slave 
device (bond_dev_queue_xmit() in bond_main.c). The only reason I can 
think of doing this is to be sure that control packet used by bonding 
specific implementation (802.3ad PDU for example) using priority 
TC_PRIO_CONTROL will never get delayed by other traffic (using the 
default qdisc pfifo_fast). The problem doing this is that priority 
information in skb get lost.
I removed this line because I need to trust skb priority in the slave 
device qdisc and I got no negative effects, am I missing something? 
There are other reason for setting skb->priority to 1?

thanks

Francesco

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-08-30 10:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-30 10:06 bonding xmit overwrite skb->priority Francesco Dolcini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).