From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] spidernet: fix interrupt reason recognition Date: Fri, 31 Aug 2007 06:46:17 -0400 Message-ID: <46D7F179.5070808@garzik.org> References: <20070820.221327.-1300518791.kouish@swc.toshiba.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linas@austin.ibm.com, netdev@vger.kernel.org, cbe-oss-dev@ozlabs.org To: Ishizaki Kou Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:49557 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756617AbXHaKq0 (ORCPT ); Fri, 31 Aug 2007 06:46:26 -0400 In-Reply-To: <20070820.221327.-1300518791.kouish@swc.toshiba.co.jp> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Ishizaki Kou wrote: > This patch solves a problem that the spidernet driver sometimes fails > to handle IRQ. > > The problem happens because, > - In Cell architecture, interrupts may arrive at an interrupt > controller, even if they are masked by the setting on registers of > devices. It happens when interrupt packets are sent just before > the interrupts are masked. > - spidernet interrupt handler compares interrupt reasons with > interrupt masks, so when such interrupts occurs, spidernet interrupt > handler returns IRQ_NONE. > - When all of interrupt handler return IRQ_NONE, linux kernel disables > the IRQ and it no longer delivers interrupts to the interrupt handlers. > > spidernet doesn't work after above sequence, because it can't receive > interrupts. > > This patch changes spidernet interrupt handler that it compares > interrupt reason with SPIDER_NET_INTX_MASK_VALUE. > > Signed-off-by: Kou Ishizaki > --- > > Linas-san, > > Please apply this to 2.6.23. Because this problem is sometimes happens > and we cannot use the ethernet port any more. > > And also, please apply the following Arnd-san's patch to fix a problem > that spidernet driver sometimes causes a BUG_ON at open. Linas? ACK? Alive? :) Jeff