From: Jeff Garzik <jeff@garzik.org>
To: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Cc: Linas Vepstas <linas@austin.ibm.com>,
netdev@vger.kernel.org, cbe-oss-dev@ozlabs.org,
geoffrey.levand@am.sony.com,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCH 1/2 v2] PS3: changed the way to handle tx skbs
Date: Fri, 31 Aug 2007 09:59:57 -0400 [thread overview]
Message-ID: <46D81EDD.5090807@garzik.org> (raw)
In-Reply-To: <20070831221800.C323.MOKUNO@sm.sony.co.jp>
Masakazu Mokuno wrote:
> The PS3 virtual network device requires a vlan tag in the sending packet
> to select the destination device, ethernet port or wireless.
> As the vlan tag field is in the middle of the passed data,
> we should insert it into the packet data.
> To avoid copying much of the packet data, the driver used two tx descriptors
> for one tx skb; one descriptor was for sending a small static
> buffer which contained vlan tag and copied header (two mac addresses),
> one was for the residual data after the vlan field.
>
> This patch changes the way to insert the vlan tag. By changing
> netdev->hard_header_len, we can make the headroom for moving mac address
> fields in the skb buffer. Then we can send one tx skb with
> one tx descriptor. This also gives us a tx throughut gain of approx.
> 20% according to netperf results.
>
> Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> CC: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
> drivers/net/ps3_gelic_net.c | 140 +++++++++++++++++++-------------------------
> 1 file changed, 63 insertions(+), 77 deletions(-)
applied 1-2, thanks for the update
next prev parent reply other threads:[~2007-08-31 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 13:17 [PATCH 0/2 v2] PS3: gelic updates Masakazu Mokuno
2007-08-31 13:22 ` [PATCH 1/2 v2] PS3: changed the way to handle tx skbs Masakazu Mokuno
2007-08-31 13:59 ` Jeff Garzik [this message]
2007-08-31 13:25 ` [PATCH 2/2 v2] PS3: Remove the workaround no longer needed Masakazu Mokuno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D81EDD.5090807@garzik.org \
--to=jeff@garzik.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=geoffrey.levand@am.sony.com \
--cc=linas@austin.ibm.com \
--cc=mokuno@sm.sony.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).