netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Bill Fink <billfink@mindspring.com>
Cc: Jesper Dangaard Brouer <hawk@diku.dk>,
	jdb@comx.dk, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO.
Date: Tue, 04 Sep 2007 18:23:26 +0200	[thread overview]
Message-ID: <46DD867E.6020307@trash.net> (raw)
In-Reply-To: <20070903233456.0e738183.billfink@mindspring.com>

Bill Fink wrote:
> On Sat, 1 Sep 2007, Jesper Dangaard Brouer wrote:
>
>>On Sat, 1 Sep 2007, Patrick McHardy wrote:
>>
>>>
>>>It still won't work properly with TSO (TBF for example already drops
>>>oversized packets during ->enqueue), but its a good cleanup anyway.
>>
>>Then lets call it a cleanup of the L2T macros.  In the next step we will 
>>fix the different schedulers, to use the ability to lookup larger sized 
>>packets. (I did notice the TBF scheduler would drop oversized packets).
> 
> 
> Hmmm.  I guess this is also why TBF doesn't seem to work with 9000 byte
> jumbo frames.
> 
> [root@lang4 ~]# tc qdisc add dev eth2 root tbf rate 2gbit buffer 5000000 limit 18000


Yes, you need to specify the MTU on the command line for
jumbo frames.

  reply	other threads:[~2007-09-04 16:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-31 12:22 [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO Jesper Dangaard Brouer
2007-09-01  7:09 ` Patrick McHardy
2007-09-01 21:38   ` Jesper Dangaard Brouer
2007-09-04  3:34     ` Bill Fink
2007-09-04 16:23       ` Patrick McHardy [this message]
2007-09-04 17:40         ` Bill Fink
2007-09-05  9:17           ` Jesper Dangaard Brouer
2007-09-06  3:59             ` Bill Fink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DD867E.6020307@trash.net \
    --to=kaber@trash.net \
    --cc=billfink@mindspring.com \
    --cc=davem@davemloft.net \
    --cc=hawk@diku.dk \
    --cc=jdb@comx.dk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).