From: Steve Wise <swise@opengridcomputing.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: netdev@vger.kernel.org, ewg@lists.openfabrics.org,
general@lists.openfabrics.org, linux-kernel@vger.kernel.org
Subject: [ofa-general] Re: [PATCH RFC] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts with the host stack.
Date: Wed, 05 Sep 2007 10:40:29 -0500 [thread overview]
Message-ID: <46DECDED.90903@opengridcomputing.com> (raw)
In-Reply-To: <ada642puonr.fsf@cisco.com>
Roland Dreier wrote:
> > > What's wrong with my suggestion of having the iwarp driver create an
> > > "iwX" interface to go with the normal "ethX" interface? It seems
> > > simpler to me, and there's a somewhat similar precedent with how
> > > mac80211 devices create both wlan0 and wmaster0 interfaces.
> > > - R.
> >
> > It seemed much more painful for me to implement. :-)
> >
> > I'll look into this, but I think for this to be done, the changes must
> > be in the cxgb3 driver, not the rdma driver, because the guts of the
> > netdev struct are all private to cxgb3. Remember that this interface
> > needs to still do non TCP traffic (like ARP and UDP)...
> >
> > Maybe you have something in mind here that I'm not thinking about?
>
> No, I was just spouting off.
>
At least someone is looking at my patch. ;-)
> But the whole "create a magic alias" seems kind of unfriendly to the
> user. Maybe as you said, the cxgb3 net driver could create the alias
> for the iw_cxgb3 driver?
I agree that it is not very user friendly.
My current patch just utilizes the IP address alias logic in the IP
stack. So when you do 'ifconfig ethxx:blah ipaddr up' it creates a
struct in_ifaddr which contains a ptr to the real struct net_device that
services this alias. However, from what I can tell, I cannot just
create one of these without binding an address. So the driver cannot
create the alias interface until it knows the ipaddr/netmask/etc. IE:
if you say 'ifconfig ethxx:blah up' it fails... You must supply an
address to get one of these created.
To have the cxgb3 driver create something like 'iw0', I think it would
need to create a full net_device struct. This makes the change much
more complex. But perhaps its the right thing to do...
Steve.
next prev parent reply other threads:[~2007-09-05 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 21:39 [ofa-general] [PATCH RFC] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts with the host stack Steve Wise
2007-08-31 4:27 ` [ofa-general] " Roland Dreier
2007-09-04 15:13 ` Steve Wise
2007-09-05 15:18 ` Roland Dreier
2007-09-05 15:40 ` Steve Wise [this message]
2007-09-05 17:27 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DECDED.90903@opengridcomputing.com \
--to=swise@opengridcomputing.com \
--cc=ewg@lists.openfabrics.org \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).