From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: 2.6.23-rc4-mm1: e1000e napi lockup Date: Sun, 09 Sep 2007 11:58:17 +0200 Message-ID: <46E3C3B9.4010500@gmail.com> References: <46E0FB82.2040000@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Andrew Morton , netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, Auke Kok , "David S. Miller" To: unlisted-recipients:; (no To-header on input) Return-path: Received: from ug-out-1314.google.com ([66.249.92.172]:8657 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756119AbXIIJ6W (ORCPT ); Sun, 9 Sep 2007 05:58:22 -0400 Received: by ug-out-1314.google.com with SMTP id z38so386275ugc for ; Sun, 09 Sep 2007 02:58:21 -0700 (PDT) In-Reply-To: <46E0FB82.2040000@gmail.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/07/2007 09:19 AM, Jiri Slaby wrote: > Hi, > > I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver. > napi_disable(&adapter->napi) in e1000_probe freezes the kernel on boot. Ok, after these changes: diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index c1c64e2..f8ec537 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c @@ -1693,10 +1693,7 @@ quit_polling: if (adapter->itr_setting & 3) e1000_set_itr(adapter); netif_rx_complete(poll_dev, napi); - if (test_bit(__E1000_DOWN, &adapter->state)) - atomic_dec(&adapter->irq_sem); - else - e1000_irq_enable(adapter); + e1000_irq_enable(adapter); return 0; } @@ -4257,7 +4254,6 @@ static int __devinit e1000_probe(struct pci_dev *pdev, /* tell the stack to leave us alone until e1000_open() is called */ netif_carrier_off(netdev); netif_stop_queue(netdev); - napi_disable(&adapter->napi); strcpy(netdev->name, "eth%d"); err = register_netdev(netdev); I still have problems with the driver. When I do `ip link set eth0 up', ksoftirq runs with 100 % cpu time, so I think you endlessly re-schedule some timer (or the new napi layer?) regards, -- Jiri Slaby (jirislaby@gmail.com) Faculty of Informatics, Masaryk University