netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Furniss <lists@andyfurniss.entadsl.com>
To: jdb@comx.dk
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Patrick McHardy <kaber@trash.net>,
	"David S. Miller" <davem@davemloft.net>,
	Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: [PATCH 4/6] [IPROUTE2]: Overhead calculation is now done in the kernel
Date: Wed, 12 Sep 2007 17:07:41 +0100	[thread overview]
Message-ID: <46E80ECD.8000605@andyfurniss.entadsl.com> (raw)
In-Reply-To: <1189592079.26927.25.camel@localhost.localdomain>

Jesper Dangaard Brouer wrote:
> commit 07a74a2613440fc1a68d0faa7235ed7027532d78
> Author: Jesper Dangaard Brouer <hawk@comx.dk>
> Date:   Tue Sep 11 16:59:58 2007 +0200
> 
>     [IPROUTE2]: Overhead calculation is now done in the kernel.
>     
>     The only current user is HTB. HTB overhead argument is now passed on
>     to the kernel (in the struct tc_ratespec). Also correct the data
>     types.

Thanks for getting this in.

It would be cool if mpu/overhead could be set per class > 255 and they 
would affect the way htb shares bandwidth.

I could be wrong but it doesn't look like this will change current 
behavior.Perhaps just allowing mpu/overhead > 255 for now, so that htb 
sharing could be fixed up in the future?

The use would be for ingress shaping, you could set a big mpu for an 
interactive class and it would cause bulk classes to get way less 
bandwidth than otherwise, so you wouldn't permanently have to sacrifice 
so much bandwidth on a slow link for latency - just when you needed to. 
It could also, with the aid of netfilter connbytes, be used to preempt 
the remote buffer filling when new bulk flows start.

One more thing, IIRC Devik acked your/Russels patch to change the 
HYSTERESIS define to 0 - any chance of resubmitting?

Thanks

Andy.


      parent reply	other threads:[~2007-09-12 16:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 10:14 [PATCH 4/6] [IPROUTE2]: Overhead calculation is now done in the kernel Jesper Dangaard Brouer
2007-09-12 11:05 ` Stephen Hemminger
2007-09-12 12:22   ` Jesper Dangaard Brouer
2007-09-12 16:07 ` Andy Furniss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E80ECD.8000605@andyfurniss.entadsl.com \
    --to=lists@andyfurniss.entadsl.com \
    --cc=davem@davemloft.net \
    --cc=jdb@comx.dk \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).