* skb configured but can't get data allocated
@ 2007-09-12 17:31 DHAJOGLO
2007-09-12 18:21 ` cc: " Macnish
2007-09-12 20:12 ` Vlad Yasevich
0 siblings, 2 replies; 3+ messages in thread
From: DHAJOGLO @ 2007-09-12 17:31 UTC (permalink / raw)
To: netdev; +Cc: kernelnewbies
Right,
I managed to figure out through looking at the code how to configure and send my skb properly. For those who say the code is well documented.. you're right.. however I fell like a blind man in an "adult book store" and just don't see what I'm missing. Below is my code. The packets are making it back and forth but the data is absent on the return trip. d_out is my little struct with two bytes and a char.
struct sk_buff *send_back(struct sk_buff *oldskb)
{
struct sk_buff *skb;
struct iphdr *iph;
struct net_device *dev = (struct net_device *)oldskb->dev;
struct rtable *rt;
int iplen;
struct ethhdr *mac;
struct exp_packet *d_out;
skb = alloc_skb(sizeof(struct exp_packet) + LL_RESERVED_SPACE(dev), GFP_ATOMIC);
if(skb == NULL)
return NULL;
/* insert the data probably need to allocatd differently */
d_out = (struct exp_packet *)skb->data;
d_out->headbits = 0xAA;
d_out->sequence = 0xBB;
d_out->payload = 0xCCDD;
/* from igmp... configure the rt */
{
struct flowi fl = { .oif = dev->ifindex,
.nl_u = { .ip4_u = {
.daddr = htonl(oldskb->nh.iph->saddr) } },
.proto = IPPROTO_EXP };
if (ip_route_output_key(&rt,&fl)) {
printk("No route?\n");
kfree_skb(skb);
return NULL;
}
}
if (rt->rt_src == 0) {
printk("No source info?\n");
ip_rt_put(rt);
return NULL;
}
skb->dst = &rt->u.dst;
skb->dev = dev;
skb_reserve(skb,LL_RESERVED_SPACE(dev));
/* configure the ipheader */
skb->nh.iph = iph = (struct iphdr *)skb_put(skb,sizeof(struct iphdr)+4);
iph->version = 4;
iph->ihl = (sizeof(struct iphdr)+4)>>2;
iph->protocol = IPPROTO_EXP;
iph->saddr = rt->rt_src;
iph->daddr = htonl(rt->rt_dst);
iph->tos = 0;
iph->ttl = 5;
ip_select_ident(iph,&rt->u.dst,NULL);
iplen = skb->tail - (unsigned char *)skb->nh.iph;
iph->tot_len = htons(iplen);
ip_send_check(iph);
skb->pkt_type = PACKET_OUTGOING;
mac = (struct ethhdr *)oldskb->mac.raw;
/* configure the mac addresses */
if(dev->hard_header && dev->hard_header(skb,dev,ETH_P_IP,mac->h_source,mac->h_dest,skb->len) < 0)
printk("hard header worked?");
return skb;
}
=== the packets look like this and they should be the same save for swapped src/dst:
00:12:3f:56:bf:1c > 00:0c:29:71:67:1e, ethertype IPv4 (0x0800), length 60: (tos 0x0, ttl 20, id 153, offset 0, flags [DF], proto: unknown (253), length: 24) src.src.src.src > dst.dst.dst.dst: ip-proto-253 4
0x0000: 4500 0018 0099 4000 14fd c4ed 8cbe 414d E.....@.......AM
0x0010: 8cbe 4599 001b ddee 0000 0000 0000 0000 ..E.............
0x0020: 0000 0000 0000 0000 0000 0000 0000 ..............
00:0c:29:71:67:1e > 00:12:3f:56:bf:1c, ethertype IPv4 (0x0800), length 38: (tos 0x0, ttl 5, id 0, offset 65528, flags [+, DF, rsvd], proto: unknown (253), length: 24, options ( unknown (243) len 252[|ip] )) src.src.src.src > dst.dst.dst.dst: ip-proto-253
0x0000: 4600 0018 0000 ffff 05fd 1f8a 8cbe 4599 F.............E.
0x0010: 8cbe 414d f3fc 0000 ..AM....
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: cc: skb configured but can't get data allocated
2007-09-12 17:31 skb configured but can't get data allocated DHAJOGLO
@ 2007-09-12 18:21 ` Macnish
2007-09-12 20:12 ` Vlad Yasevich
1 sibling, 0 replies; 3+ messages in thread
From: Macnish @ 2007-09-12 18:21 UTC (permalink / raw)
To: DHAJOGLO; +Cc: netdev, kernelnewbies
DHAJOGLO escreveu:
> Right,
> I managed to figure out through looking at the code how to configure and send my skb properly. For those who say the code is well documented.. you're right.. however I fell like a blind man in an "adult book store" and just don't see what I'm missing. Below is my code. The packets are making it back and forth but the data is absent on the return trip. d_out is my little struct with two bytes and a char.
>
>
>
> struct sk_buff *send_back(struct sk_buff *oldskb)
> {
> struct sk_buff *skb;
> struct iphdr *iph;
> struct net_device *dev = (struct net_device *)oldskb->dev;
> struct rtable *rt;
> int iplen;
> struct ethhdr *mac;
> struct exp_packet *d_out;
>
> skb = alloc_skb(sizeof(struct exp_packet) + LL_RESERVED_SPACE(dev), GFP_ATOMIC);
> if(skb == NULL)
> return NULL;
>
> /* insert the data probably need to allocatd differently */
> d_out = (struct exp_packet *)skb->data;
> d_out->headbits = 0xAA;
> d_out->sequence = 0xBB;
> d_out->payload = 0xCCDD;
>
> /* from igmp... configure the rt */
> {
> struct flowi fl = { .oif = dev->ifindex,
> .nl_u = { .ip4_u = {
> .daddr = htonl(oldskb->nh.iph->saddr) } },
> .proto = IPPROTO_EXP };
> if (ip_route_output_key(&rt,&fl)) {
> printk("No route?\n");
> kfree_skb(skb);
> return NULL;
> }
> }
> if (rt->rt_src == 0) {
> printk("No source info?\n");
> ip_rt_put(rt);
> return NULL;
> }
>
> skb->dst = &rt->u.dst;
> skb->dev = dev;
>
> skb_reserve(skb,LL_RESERVED_SPACE(dev));
>
> /* configure the ipheader */
> skb->nh.iph = iph = (struct iphdr *)skb_put(skb,sizeof(struct iphdr)+4);
>
> iph->version = 4;
> iph->ihl = (sizeof(struct iphdr)+4)>>2;
> iph->protocol = IPPROTO_EXP;
> iph->saddr = rt->rt_src;
> iph->daddr = htonl(rt->rt_dst);
> iph->tos = 0;
> iph->ttl = 5;
> ip_select_ident(iph,&rt->u.dst,NULL);
> iplen = skb->tail - (unsigned char *)skb->nh.iph;
> iph->tot_len = htons(iplen);
> ip_send_check(iph);
>
>
> skb->pkt_type = PACKET_OUTGOING;
>
> mac = (struct ethhdr *)oldskb->mac.raw;
>
> /* configure the mac addresses */
> if(dev->hard_header && dev->hard_header(skb,dev,ETH_P_IP,mac->h_source,mac->h_dest,skb->len) < 0)
> printk("hard header worked?");
>
> return skb;
> }
>
> === the packets look like this and they should be the same save for swapped src/dst:
>
> 00:12:3f:56:bf:1c > 00:0c:29:71:67:1e, ethertype IPv4 (0x0800), length 60: (tos 0x0, ttl 20, id 153, offset 0, flags [DF], proto: unknown (253), length: 24) src.src.src.src > dst.dst.dst.dst: ip-proto-253 4
> 0x0000: 4500 0018 0099 4000 14fd c4ed 8cbe 414d E.....@.......AM
> 0x0010: 8cbe 4599 001b ddee 0000 0000 0000 0000 ..E.............
> 0x0020: 0000 0000 0000 0000 0000 0000 0000 ..............
> 00:0c:29:71:67:1e > 00:12:3f:56:bf:1c, ethertype IPv4 (0x0800), length 38: (tos 0x0, ttl 5, id 0, offset 65528, flags [+, DF, rsvd], proto: unknown (253), length: 24, options ( unknown (243) len 252[|ip] )) src.src.src.src > dst.dst.dst.dst: ip-proto-253
> 0x0000: 4600 0018 0000 ffff 05fd 1f8a 8cbe 4599 F.............E.
> 0x0010: 8cbe 414d f3fc 0000 ..AM....
>
>
> --
> To unsubscribe from this list: send an email with
> "unsubscribe kernelnewbies" to ecartis@nl.linux.org
> Please read the FAQ at http://kernelnewbies.org/FAQ
>
>
>
Am I missing something or the d_out struct hadn't been put inside the skb?
--
Best Regards
Alan Menegotto
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: skb configured but can't get data allocated
2007-09-12 17:31 skb configured but can't get data allocated DHAJOGLO
2007-09-12 18:21 ` cc: " Macnish
@ 2007-09-12 20:12 ` Vlad Yasevich
1 sibling, 0 replies; 3+ messages in thread
From: Vlad Yasevich @ 2007-09-12 20:12 UTC (permalink / raw)
To: DHAJOGLO; +Cc: netdev, kernelnewbies
You may want to read this page:
http://vger.kernel.org/~davem/skb.html
You will then see you problem.
Essentially, you are writing your data into an
area that is never sent.
What you are end up is this:
---------------------------------------------
| your data| space | ll-header | IPv4 header|
---------------------------------------------
-vlad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-12 20:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-12 17:31 skb configured but can't get data allocated DHAJOGLO
2007-09-12 18:21 ` cc: " Macnish
2007-09-12 20:12 ` Vlad Yasevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).