netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jeff@garzik.org,
	jesse.brandeburg@intel.com
Subject: Re: [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git
Date: Wed, 12 Sep 2007 15:20:01 -0700	[thread overview]
Message-ID: <46E86611.60307@intel.com> (raw)
In-Reply-To: <20070912151643.cb0e070b.akpm@linux-foundation.org>

Andrew Morton wrote:
> On Wed, 12 Sep 2007 11:13:07 -0700
> Auke Kok <auke-jan.h.kok@intel.com> wrote:
> 
>> This incorporates the new napi_struct changes into ixgbe.
> 
> I get a reject storm.
> 
>> --- a/drivers/net/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ixgbe/ixgbe_main.c
>> @@ -557,14 +557,15 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
>>  	struct ixgbe_adapter *adapter = rxr->adapter;
>>  
>>  	IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, rxr->eims_value);
>> -	netif_rx_schedule(adapter->netdev);
>> +	netif_rx_schedule(adapter->netdev, &adapter->napi);
>>  	return IRQ_HANDLED;
>>  }
>>  
> 
> For example, my copy of ixgbe_msix_clean_rx(), from
> git://lost.foo-projects.org/~aveerani/git/linux-2.6#ixgbe is:

please drop that tree, and get the one I posted last week instead:

git://lost.foo-projects.org/~ahkok/linux-2.6 ixgbe-20070905-submission

or:

   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch
   http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch.bz2


Cheers,

Auke

  reply	other threads:[~2007-09-12 22:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 18:13 [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git Auke Kok
2007-09-12 22:16 ` Andrew Morton
2007-09-12 22:20   ` Kok, Auke [this message]
2007-09-12 23:14     ` Andrew Morton
2007-09-12 23:29       ` Kok, Auke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E86611.60307@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).