From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 2.6.24 1/5]S2io: Enable all the error and alarm indications Date: Thu, 13 Sep 2007 00:04:18 -0400 Message-ID: <46E8B6C2.5080507@garzik.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, support@neterion.com To: Sivakumar Subramani Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:52892 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbXIMEEU (ORCPT ); Thu, 13 Sep 2007 00:04:20 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Sivakumar Subramani wrote: > - Added support to unmask entire set of device errors and alarams. > Alarm interrupts are generated for a myriad of purposes, ranging from > illegal operations or requests to internal state machine errors and > uncorrectable data corruption errors. In several cases the adapter can > recover gracefully from unexpected events; however, in some cases, a device > reset may be necessary. This patch handles alarms generated by all the > blocks within the device. > > The adapter generates the following types of alarms: > 1. Link state transitions (local/remote fault) or other link-related > problems. > 2. Problems with any device peripherals, including the EEPROM, FLASH, > etc. > 3. Correctable ECC errors (single-bit errors) on internal data > structures or frame data. > 4. Uncorrectable ECC errors (multi-bit errors) on internal data > structures or frame data. > 5. State machine errors, which indicate that internal control > structures have become corrupted. > 6. PCI related errors, including parity errors or illegal transactions. > 7. Other unexpected events. > > - Implemented Jeff's review comments to use do_s2io_write_bits function to avoid > duplicate codes. > > Signed-off-by: Sivakumar Subramani > Signed-off-by: Santosh Rastapur > Signed-off-by: Ramkrishna Vepa applied 1-5 to #upstream (2.6.24)