netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Cc: linas@austin.ibm.com, netdev@vger.kernel.org, cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH] spidernet: fix interrupt reason recognition
Date: Thu, 13 Sep 2007 00:19:46 -0400	[thread overview]
Message-ID: <46E8BA62.1090802@garzik.org> (raw)
In-Reply-To: <20070820.221327.-1300518791.kouish@swc.toshiba.co.jp>

Ishizaki Kou wrote:
> This patch solves a problem that the spidernet driver sometimes fails
> to handle IRQ.
> 
> The problem happens because,
> - In Cell architecture, interrupts may arrive at an interrupt
>   controller, even if they are masked by the setting on registers of
>   devices. It happens when interrupt packets are sent just before 
>   the interrupts are masked.
> - spidernet interrupt handler compares interrupt reasons with
>   interrupt masks, so when such interrupts occurs, spidernet interrupt
>   handler returns IRQ_NONE.
> - When all of interrupt handler return IRQ_NONE, linux kernel disables
>   the IRQ and it no longer delivers interrupts to the interrupt handlers.
> 
> spidernet doesn't work after above sequence, because it can't receive
> interrupts.
>  
> This patch changes spidernet interrupt handler that it compares
> interrupt reason with SPIDER_NET_INTX_MASK_VALUE.
> 
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>

applied



      parent reply	other threads:[~2007-09-13  4:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20 13:13 [PATCH] spidernet: fix interrupt reason recognition Ishizaki Kou
2007-08-20 22:38 ` Linas Vepstas
2007-08-22  0:26   ` [Cbe-oss-dev] " Ishizaki Kou
2007-08-29  8:58     ` Ishizaki Kou
2007-08-31 10:46 ` Jeff Garzik
2007-09-04 23:49   ` Linas Vepstas
2007-09-13  4:19 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E8BA62.1090802@garzik.org \
    --to=jeff@garzik.org \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=kou.ishizaki@toshiba.co.jp \
    --cc=linas@austin.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).