From: Sean Hefty <mshefty@ichips.intel.com>
To: Steve Wise <swise@opengridcomputing.com>
Cc: netdev@vger.kernel.org, rdreier@cisco.com,
general@lists.openfabrics.org, linux-kernel@vger.kernel.org
Subject: Re: [ofa-general] [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts.
Date: Thu, 13 Sep 2007 12:54:46 -0700 [thread overview]
Message-ID: <46E99586.90905@ichips.intel.com> (raw)
In-Reply-To: <20070913191617.30937.95960.stgit@dell3.ogc.int>
> The iWARP driver must translate all listens on address 0.0.0.0 to the
> set of rdma-only ip addresses for the device in question. This prevents
> incoming connect requests to the TCP ipaddresses from going up the
> rdma stack.
I've only given this a high level review at this point, and while the
patch looks okay on first pass, is there a way to move some of this
functionality to either the rdma_cm or iw_cm? I don't like the idea of
every iwarp driver having to implement address/listen list maintenance.
I may have some ideas after re-examining it.
> Implementation Details:
There are a couple of areas that I made a note to look at in more detail
(because I didn't understand everything that was happening), but I did
have one minor nit - most uses of list_del_init can just be list_del.
- Sean
next prev parent reply other threads:[~2007-09-13 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 19:16 [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts Steve Wise
2007-09-13 19:54 ` Sean Hefty [this message]
2007-09-15 14:07 ` [ofa-general] " Steve Wise
2007-09-23 20:33 ` Steve Wise
2007-09-14 13:09 ` [ofa-general] " Evgeniy Polyakov
2007-09-14 16:06 ` Roland Dreier
2007-09-15 15:56 ` Steve Wise
2007-09-16 14:22 ` [ofa-general] " Evgeniy Polyakov
2007-09-17 15:25 ` Steve Wise
2007-09-19 10:56 ` Evgeniy Polyakov
2007-09-21 15:10 ` [ofa-general] " Steve Wise
2007-09-17 16:09 ` Sean Hefty
2007-09-17 16:17 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E99586.90905@ichips.intel.com \
--to=mshefty@ichips.intel.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).