From: Jeff Garzik <jeff@garzik.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] jumbo all-NICs ethtool count cleanup
Date: Sun, 16 Sep 2007 03:39:12 -0400 [thread overview]
Message-ID: <46ECDDA0.3070701@garzik.org> (raw)
In-Reply-To: <20070916062722.GA5498@uranus.ravnborg.org>
Sam Ravnborg wrote:
> Hi Jeff.
>
> You wrote:
>> The hooks ->self_test_count() and ->get_stats_count() are now unused
>> in the main tree.
>
> So I'm suprised to see more lines added than deleted:
>> 35 files changed, 346 insertions(+), 246 deletions(-)
>
> Puzzled - may need a bit more coffee (morning here)..
The new interface that supercedes these is ->get_sset_count(), which was
added to provide additional functionality without having to add a new
hook each time we want to return a new integer value. This new
interface also (intentionally) aligns with the existing ->get_strings()
interface. ("sset" in get_sset_count stands for "string set")
Jeff
prev parent reply other threads:[~2007-09-16 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 6:10 [PATCH] jumbo all-NICs ethtool count cleanup Jeff Garzik
2007-09-16 6:27 ` Sam Ravnborg
2007-09-16 7:39 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ECDDA0.3070701@garzik.org \
--to=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).