From: Daniel Lezcano <dlezcano@fr.ibm.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: dlezcano@fr.ibm.com, netdev@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
containers@lists.osdl.org, davem@davemloft.net,
Benjamin Thery <benjamin.thery@bull.net>
Subject: Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device
Date: Mon, 17 Sep 2007 20:52:05 +0200 [thread overview]
Message-ID: <46EECCD5.5090601@fr.ibm.com> (raw)
In-Reply-To: <20070917101314.5d1673da@freepuppy.rosehill.hemminger.net>
Stephen Hemminger wrote:
> On Mon, 17 Sep 2007 15:45:11 +0200
> dlezcano@fr.ibm.com wrote:
>
>> From: Daniel Lezcano <dlezcano@fr.ibm.com>
>>
>> Doing this makes loopback.c a better example of how to do a
>> simple network device, and it removes the special case
>> single static allocation of a struct net_device, hopefully
>> making maintenance easier.
>>
>
> What is before/after code and data size, does it make code smaller?
Interesting question, here are the results based on the same config file.
Without the patchset:
----------------------
vmlinux:
text data bss dec hex filename
2446606 188243 163840 2798689 2ab461 vmlinux
loopback.o
text data bss dec hex filename
417 1040 8 1465 5b9 drivers/net/loopback.o
With the patchset:
------------------
vmlinux:
text data bss dec hex filename
2446853 187187 163840 2797880 2ab138 ./vmlinux
loopback.o
text data bss dec hex filename
609 4 12 625 271 drivers/net/loopback.o
next prev parent reply other threads:[~2007-09-17 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 13:45 [net-2.6.24][patch 0/2] Dynamically allocate the loopback dlezcano
2007-09-17 13:45 ` [net-2.6.24][patch 1/2] Dynamically allocate the loopback device - mindless changes dlezcano
2007-09-17 13:45 ` [net-2.6.24][patch 2/2] Dynamically allocate the loopback device dlezcano
2007-09-17 17:13 ` Stephen Hemminger
2007-09-17 18:52 ` Daniel Lezcano [this message]
[not found] ` <46EECCD5.5090601-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-09-17 19:12 ` Peter Waskiewicz
2007-09-18 1:53 ` David Miller
2007-09-18 2:44 ` Eric W. Biederman
2007-09-26 2:24 ` David Miller
2007-09-26 21:40 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EECCD5.5090601@fr.ibm.com \
--to=dlezcano@fr.ibm.com \
--cc=benjamin.thery@bull.net \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).