netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Heffner <jheffner@psc.edu>
To: Rick Jones <rick.jones2@hp.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] include listenq max/backlog in tcp_info and related	reports - correct version/signorder
Date: Mon, 17 Sep 2007 16:44:58 -0400	[thread overview]
Message-ID: <46EEE74A.9090003@psc.edu> (raw)
In-Reply-To: <46EEE3D4.2070906@hp.com>

Rick Jones wrote:
> John Heffner wrote:
>> Any reason you're overloading tcpi_unacked and tcpi_sacked?  It seems 
>> that setting idiag_rqueue and idiag_wqueue are sufficient.
> 
> Different fields for different structures.   The tcp_info struct doesn't 
> have the idiag_mumble, so to get the two values shown in /proc/net/tcp I 
> use tcpi_unacked and tcpi_sacked.
> 
> For the INET_DIAG_INFO stuff the idiag_mumble fields are used and that 
> then covers ss.

Maybe I'm missing something.  get_tcp[46]_sock() does not use struct 
tcp_info.  The only way I see using this is by doing 
getsockopt(TCP_INFO) on your listen socket.  Is this the intention?

   -John


  reply	other threads:[~2007-09-17 20:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-17 19:50 [PATCH] include listenq max/backlog in tcp_info and related reports - correct version/signorder Rick Jones
2007-09-17 20:06 ` John Heffner
2007-09-17 20:30   ` Rick Jones
2007-09-17 20:44     ` John Heffner [this message]
2007-09-17 22:48       ` Rick Jones
2007-09-17 21:26     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2007-09-12  0:38 Rick Jones
2007-09-17 18:38 ` Rick Jones
2007-09-17 19:01   ` David Miller
2007-09-17 19:51     ` Rick Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46EEE74A.9090003@psc.edu \
    --to=jheffner@psc.edu \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).