From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Jones Subject: Re: [PATCH] include listenq max/backlog in tcp_info and related reports - correct version/signorder Date: Mon, 17 Sep 2007 15:48:07 -0700 Message-ID: <46EF0427.20503@hp.com> References: <200709171950.MAA14825@tardy.cup.hp.com> <46EEDE35.8090102@psc.edu> <46EEE3D4.2070906@hp.com> <46EEE74A.9090003@psc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: John Heffner Return-path: Received: from palrel13.hp.com ([156.153.255.238]:44369 "EHLO palrel13.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753814AbXIQWsk (ORCPT ); Mon, 17 Sep 2007 18:48:40 -0400 In-Reply-To: <46EEE74A.9090003@psc.edu> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org John Heffner wrote: > Rick Jones wrote: > >> John Heffner wrote: >> >>> Any reason you're overloading tcpi_unacked and tcpi_sacked? It seems >>> that setting idiag_rqueue and idiag_wqueue are sufficient. >> >> >> Different fields for different structures. The tcp_info struct >> doesn't have the idiag_mumble, so to get the two values shown in >> /proc/net/tcp I use tcpi_unacked and tcpi_sacked. >> >> For the INET_DIAG_INFO stuff the idiag_mumble fields are used and that >> then covers ss. > > > Maybe I'm missing something. get_tcp[46]_sock() does not use struct > tcp_info. The only way I see using this is by doing > getsockopt(TCP_INFO) on your listen socket. Is this the intention? Yes. Sorry I got a triffle turned-around there. rick