From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 2/7] CAN: Add PF_CAN core module Date: Tue, 18 Sep 2007 17:07:58 +0200 Message-ID: <46EFE9CE.4060901@trash.net> References: <20070917100321.18347.0@janus.isnogud.escape.de> <20070917100438.18347.2@janus.isnogud.escape.de> <46EFD33D.8030905@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, David Miller , Thomas Gleixner , Oliver Hartkopp , Oliver Hartkopp To: Urs Thuermann Return-path: Received: from stinky.trash.net ([213.144.137.162]:39542 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757773AbXIRPOg (ORCPT ); Tue, 18 Sep 2007 11:14:36 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Urs Thuermann wrote: > Patrick McHardy writes: > > >>Looks pretty good, please see below for a few comments (mostly minor >>nitpicking, a few things that look like real bugs). Nothing that >>couldn't be fixed after merging though. > > > Thank you for your review. I'll go through it and your other mail > this evening/tonight. From a fast overview it looks like most issues > can be fixed/changed quite easily. Agreed. No objections to putting this in 2.6.24 from my side ..