From: Moni Shoua <monis@voltaire.com>
To: Roland Dreier <rdreier@cisco.com>, Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com, davem@davemloft.net,
general@lists.openfabrics.org
Subject: Re: [ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister
Date: Wed, 19 Sep 2007 19:41:57 +0300 [thread overview]
Message-ID: <46F15155.4070708@voltaire.com> (raw)
In-Reply-To: <ada3axblvj2.fsf@cisco.com>
Roland, Jay,
Thanks a lot for the comments.
I'd like to summarize the points raised so far
1. Reduce the indentation in patch #4 (Roland)
I will resend
2. Remove the "if (n->dev->flags & IFF_MASTER)" from patch #3 (Roland)
I will resend
3. Consider making ipoib_slave_detach() net/core/dev.c (Roland, Jay)
I think that this is a good idea. I can make the patch (and necessary changes to
the other patches) assuming this is agreed by all.
4. Change header for patch #1 (Roland)
I will resend
5. Use NETDEV_GOING_DOWN and not NETDEV_CHANGE + IFF_SLAVE_DETACH (Jay)
The NETDEV_GOING_DOWN event is sent in the contex of unregister_netdevice()
Since the action in bonding to the event should be unregister the bonding master
it is not possible to do so. bonding needs to know about the slave detach earlier.
6. call notifiers from unregister_netdev()
See answer to 5.
7. missing call to notifiers in ipoib_vlan_delete() (Roland)
It seems like you're right. I will fix and resend.
I think that if there are no other comments, I will submit the entire 11 patches
again (with changes) to make it easier to merge into the kernel. Since the most of the
content in the patch series is in bonding I thought it would be right that Jay will
push all the patches to the networking git. Is it OK with you Roland?
next prev parent reply other threads:[~2007-09-19 16:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 23:40 [ofa-general] [PATCH 00/11] IPoIB support for bonding Jay Vosburgh
2007-09-14 23:40 ` [PATCH 01/11] IB/ipoib: Export call to call_netdevice_notifiers and add new private flag Jay Vosburgh
2007-09-14 23:40 ` [ofa-general] [PATCH 02/11] IB/ipoib: Notify the world before doing unregister Jay Vosburgh
2007-09-14 23:40 ` [PATCH 03/11] IB/ipoib: Bound the net device to the ipoib_neigh structue Jay Vosburgh
2007-09-14 23:40 ` [PATCH 04/11] IB/ipoib: Verify address handle validity on send Jay Vosburgh
2007-09-14 23:40 ` [PATCH 05/11] net/bonding: Enable bonding to enslave non ARPHRD_ETHER Jay Vosburgh
2007-09-14 23:40 ` [PATCH 06/11] net/bonding: Enable bonding to enslave netdevices not supporting set_mac_address() Jay Vosburgh
2007-09-14 23:40 ` [PATCH 07/11] net/bonding: Enable IP multicast for bonding IPoIB devices Jay Vosburgh
2007-09-14 23:40 ` [PATCH 08/11] net/bonding: Handle wrong assumptions that slave is always an Ethernet device Jay Vosburgh
2007-09-14 23:40 ` [PATCH 9/11] net/bonding: Delay sending of gratuitous ARP to avoid failure Jay Vosburgh
2007-09-14 23:40 ` [PATCH 10/11] net/bonding: Destroy bonding master when last slave is gone Jay Vosburgh
2007-09-14 23:40 ` [PATCH 11/11] bonding: Optionally allow ethernet slaves to keep own MAC Jay Vosburgh
2007-09-17 22:20 ` [PATCH 04/11] IB/ipoib: Verify address handle validity on send Roland Dreier
2007-09-17 22:23 ` [ofa-general] Re: [PATCH 03/11] IB/ipoib: Bound the net device to the ipoib_neigh structue Roland Dreier
2007-09-17 22:22 ` [ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister Roland Dreier
2007-09-17 22:25 ` Roland Dreier
2007-09-17 23:23 ` Jay Vosburgh
2007-09-17 23:33 ` Roland Dreier
2007-09-18 17:42 ` [ofa-general] " Roland Dreier
2007-09-19 16:41 ` Moni Shoua [this message]
2007-09-19 16:44 ` Roland Dreier
2007-09-17 22:17 ` [ofa-general] Re: [PATCH 01/11] IB/ipoib: Export call to call_netdevice_notifiers and add new private flag Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F15155.4070708@voltaire.com \
--to=monis@voltaire.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).