From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org,
Ariel.Hendel@sun.com, greg.onufer@sun.com
Subject: Re: [PATCH]: Preliminary release of Sun Neptune driver
Date: Wed, 19 Sep 2007 18:40:05 -0400 [thread overview]
Message-ID: <46F1A545.7010700@garzik.org> (raw)
In-Reply-To: <20070919.150755.38714639.davem@davemloft.net>
David Miller wrote:
>> Macro's that make assumptions about context (ie variable name np)
>> are evil and bad style.
>
> Too bad, it saves developers who write 20,000 line drivers from carpel
> tunnel symdrome.
>
> It's so repetitive to state things over and over again, and this macro
> scheme is 1) established widely (tg3 amonst many other drivers do it)
> and 2) forces the driver to use a consistent naming convention for
> primary driver private struct variables.
It also makes review easier -- IMO an important factor.
Which is more clear at a glance:
status = tr32(MAC_STAT_1);
or
status = foo_mac_read32(priv, MAC_STAT_1);
?
tg3 and other net drivers show that this technique improves code
readability.
Jeff
next prev parent reply other threads:[~2007-09-19 22:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 22:15 [PATCH]: Preliminary release of Sun Neptune driver David Miller
2007-09-19 21:59 ` Stephen Hemminger
2007-09-19 22:05 ` Jeff Garzik
2007-09-19 22:11 ` David Miller
2007-09-19 22:37 ` Jeff Garzik
2007-09-19 22:07 ` David Miller
2007-09-19 22:40 ` Jeff Garzik [this message]
2007-09-19 23:05 ` Stephen Hemminger
2007-09-19 23:17 ` David Miller
2007-09-19 23:20 ` Rick Jones
2007-09-19 23:53 ` David Miller
2007-09-20 16:06 ` Ariel Hendel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F1A545.7010700@garzik.org \
--to=jeff@garzik.org \
--cc=Ariel.Hendel@sun.com \
--cc=davem@davemloft.net \
--cc=greg.onufer@sun.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).