From: Rick Jones <rick.jones2@hp.com>
To: David Miller <davem@davemloft.net>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org, Ariel.Hendel@sun.com,
greg.onufer@sun.com, jeff@garzik.org
Subject: Re: [PATCH]: Preliminary release of Sun Neptune driver
Date: Wed, 19 Sep 2007 16:20:39 -0700 [thread overview]
Message-ID: <46F1AEC7.8090604@hp.com> (raw)
In-Reply-To: <20070919145900.759ef19e@freepuppy.rosehill.hemminger.net>
>>+#define DRV_MODULE_NAME "niu"
>>+#define PFX DRV_MODULE_NAME ": "
>>+#define DRV_MODULE_VERSION "0.06"
>>+#define DRV_MODULE_RELDATE "September 18, 2007"
>>+
>>+static char version[] __devinitdata =
>>+ DRV_MODULE_NAME ".c:v" DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n";
>>+
>>+MODULE_AUTHOR("David S. Miller (davem@davemloft.net)");
>>+MODULE_DESCRIPTION("NIU ethernet driver");
>>+MODULE_LICENSE("GPL");
>>+MODULE_VERSION(DRV_MODULE_VERSION);
A somewhat pedantic question... some grepping in a kernel tree suggests
the obvious name "netptune" is at least already taken for PCI ID macros:
hpcpc105:~/linux-2.6.23-rc5# grep -i neptune ./drivers/scsi/lpfc/lpfc_hw.h
#define PCI_DEVICE_ID_NEPTUNE 0xf0f5
#define PCI_DEVICE_ID_NEPTUNE_SCSP 0xf0f6
#define PCI_DEVICE_ID_NEPTUNE_DCSP 0xf0f7
and shows-up in comments elsewhere, but that same (perhaps too cursory?)
search didn't seem to find "neptune" used as an actual module/driver
name, so why "niu?" To what does niu translate anyway?
sincerely,
rick jones
now left with the quandry of whether to run netperf against a driver for
a card from a .com other than his own or an OEM :) On the plus side
though, this driver has no EULA restrictions :)
next prev parent reply other threads:[~2007-09-19 23:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 22:15 [PATCH]: Preliminary release of Sun Neptune driver David Miller
2007-09-19 21:59 ` Stephen Hemminger
2007-09-19 22:05 ` Jeff Garzik
2007-09-19 22:11 ` David Miller
2007-09-19 22:37 ` Jeff Garzik
2007-09-19 22:07 ` David Miller
2007-09-19 22:40 ` Jeff Garzik
2007-09-19 23:05 ` Stephen Hemminger
2007-09-19 23:17 ` David Miller
2007-09-19 23:20 ` Rick Jones [this message]
2007-09-19 23:53 ` David Miller
2007-09-20 16:06 ` Ariel Hendel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F1AEC7.8090604@hp.com \
--to=rick.jones2@hp.com \
--cc=Ariel.Hendel@sun.com \
--cc=davem@davemloft.net \
--cc=greg.onufer@sun.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).