From: Rick Jones <rick.jones2@hp.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Jeff Garzk <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/6] sky2: reorganize chip revision features
Date: Wed, 19 Sep 2007 16:27:26 -0700 [thread overview]
Message-ID: <46F1B05E.9010209@hp.com> (raw)
In-Reply-To: <20070919223746.612168285@linux-foundation.org>
Stephen Hemminger wrote:
> This patch should cause no functional changes in driver behaviour.
> There are (too) many revisions of the Yukon 2 chip now. Instead of
> adding more conditionals based on chip revision; rerganize into a
> set of feature flags so adding new versions is less problematic.
> @@ -311,10 +310,8 @@ static void sky2_phy_init(struct sky2_hw
> struct sky2_port *sky2 = netdev_priv(hw->dev[port]);
> u16 ctrl, ct1000, adv, pg, ledctrl, ledover, reg;
>
> - if (sky2->autoneg == AUTONEG_ENABLE
> - && !(hw->chip_id == CHIP_ID_YUKON_XL
> - || hw->chip_id == CHIP_ID_YUKON_EC_U
> - || hw->chip_id == CHIP_ID_YUKON_EX)) {
> + if (sky2->autoneg == AUTONEG_ENABLE &&
> + !(hw->flags & SKY2_HW_NEWER_PHY)) {
Will something like SKY2_HW_NEWER_PHY age well? Won't that leave things
vulnerable to needing a SKY2_HW_NEWER_NEWER_PHY?
> @@ -1436,13 +1428,15 @@ static int sky2_xmit_frame(struct sk_buf
> /* Check for TCP Segmentation Offload */
> mss = skb_shinfo(skb)->gso_size;
> if (mss != 0) {
> - if (hw->chip_id != CHIP_ID_YUKON_EX)
> +
> + if (!(hw->flags & SKY2_HW_NEW_LE))
> mss += ETH_HLEN + ip_hdrlen(skb) + tcp_hdrlen(skb);
Might the same thing apply with SKY2_HW_NEW_LE?
rick jones
next prev parent reply other threads:[~2007-09-19 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 22:36 [PATCH 0/6] sky2: version 1.18 (rev2) Stephen Hemminger
2007-09-19 22:36 ` [PATCH 1/6] sky2: fix VLAN receive processing (resend) Stephen Hemminger
2007-09-20 3:47 ` Jeff Garzik
2007-09-19 22:36 ` [PATCH 2/6] sky2: ethtool speed report bug Stephen Hemminger
2007-09-19 22:36 ` [PATCH 3/6] sky2: reorganize chip revision features Stephen Hemminger
2007-09-19 23:27 ` Rick Jones [this message]
2007-09-19 22:36 ` [PATCH 4/6] sky2: fe+ chip support Stephen Hemminger
2007-09-19 22:36 ` [PATCH 5/6] sky2: receive FIFO checking Stephen Hemminger
2007-09-19 22:36 ` [PATCH 6/6] sky2: version 1.18 Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2007-09-20 5:05 [PATCH 0/6] sky2: merged for netdev-2.6 upstream Stephen Hemminger
2007-09-20 5:06 ` [PATCH 3/6] sky2: reorganize chip revision features Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F1B05E.9010209@hp.com \
--to=rick.jones2@hp.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).