From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: be more selective about FIFO watchdog
Date: Thu, 20 Sep 2007 17:46:01 -0400 [thread overview]
Message-ID: <46F2EA19.7040805@pobox.com> (raw)
In-Reply-To: <20070920143046.61fce43b@freepuppy.rosehill>
Stephen Hemminger wrote:
> On Thu, 20 Sep 2007 16:51:13 -0400
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>> Stephen Hemminger wrote:
>>> Be more selective about when to enable the ram buffer watchdog code.
>>> It is unnecessary on XL A3 or later revs, and with Yukon FE
>>> the buffer is so small (4K) that the watchdog detects false positives.
>>>
>>> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>> With all the sky2 patches flying about, it would be wise to include
>> notes like "applies to 2.6.23-rc" or "net-2.6.24" after the standard
>> "---" terminator.
>>
>> is this patch supposed to go on top of the sky2 patches that Linus just
>> pulled?
>>
>>
> It can go after previous 6 on both 2.6.23-rc and net-2.6.24 (with fuzz)
Is it _needed_ in 2.6.23-rc, Mr. Maintainer? :)
The answer to that question is not clear to me, given the description
and code.
Jeff
next prev parent reply other threads:[~2007-09-20 21:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 20:03 [PATCH] sky2: be more selective about FIFO watchdog Stephen Hemminger
2007-09-20 20:51 ` Jeff Garzik
2007-09-20 21:30 ` Stephen Hemminger
2007-09-20 21:46 ` Jeff Garzik [this message]
2007-09-20 22:33 ` Stephen Hemminger
2007-09-25 4:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F2EA19.7040805@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).