From: Steve Wise <swise@opengridcomputing.com>
To: Ben Greear <greearb@candelatech.com>
Cc: hadi@cyberus.ca, Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
netdev@vger.kernel.org, Robert Olsson <Robert.Olsson@data.slu.se>
Subject: Re: pktgen question
Date: Mon, 24 Sep 2007 10:00:58 -0500 [thread overview]
Message-ID: <46F7D12A.7020607@opengridcomputing.com> (raw)
In-Reply-To: <46F7CC09.6070603@candelatech.com>
Ben Greear wrote:
> Steve Wise wrote:
>> I think pktgen should be cloning the skbs using skb_clone(). Then it
>> will work for all devices, eh?
> That might work, but it would decrease performance slightly (or,
> increase CPU load at least).
Perf-wise, you could clone the skbs up front, then deliver them to the
nic in a tight loop. This would mitigate the added overhead introduced
by calling skb_clone() in the loop doing transmits...
>
> Maybe a new option: multi_clone
>
If the current code is busted, I think it should be fixed.
My 2 cents.
Steve.
next prev parent reply other threads:[~2007-09-24 15:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 16:12 pktgen question Steve Wise
2007-09-23 17:28 ` Evgeniy Polyakov
2007-09-23 17:55 ` Steve Wise
2007-09-23 18:18 ` jamal
2007-09-24 6:30 ` Ben Greear
2007-09-24 13:54 ` Steve Wise
2007-09-24 14:39 ` Ben Greear
2007-09-24 15:00 ` Steve Wise [this message]
2007-09-24 15:37 ` Ben Greear
2007-09-24 18:02 ` Rick Jones
2007-09-24 18:22 ` Ben Greear
2007-10-08 21:43 ` Steve Wise
2007-10-08 21:57 ` Ben Greear
2007-10-08 22:22 ` David Miller
2007-10-08 22:46 ` Steve Wise
2007-10-08 22:54 ` David Miller
2007-09-24 15:42 ` Robert Olsson
2007-09-24 17:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F7D12A.7020607@opengridcomputing.com \
--to=swise@opengridcomputing.com \
--cc=Robert.Olsson@data.slu.se \
--cc=greearb@candelatech.com \
--cc=hadi@cyberus.ca \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).