From: Moni Shoua <monisonlists@gmail.com>
To: Roland Dreier <rdreier@cisco.com>, Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org,
OpenFabrics General <general@lists.openfabrics.org>
Subject: [PATCH V6 6/9] net/bonding: Handlle wrong assumptions that slave is always an Ethernet device
Date: Mon, 24 Sep 2007 17:40:57 +0200 [thread overview]
Message-ID: <46F7DA89.1050403@gmail.com> (raw)
In-Reply-To: <46F7D770.4090500@voltaire.com>
bonding sometimes uses Ethernet constants (such as MTU and address length) which
are not good when it enslaves non Ethernet devices (such as InfiniBand).
Signed-off-by: Moni Shoua <monis at voltaire.com>
---
drivers/net/bonding/bond_main.c | 3 ++-
drivers/net/bonding/bond_sysfs.c | 10 ++++++++--
drivers/net/bonding/bonding.h | 1 +
3 files changed, 11 insertions(+), 3 deletions(-)
Index: net-2.6/drivers/net/bonding/bond_main.c
===================================================================
--- net-2.6.orig/drivers/net/bonding/bond_main.c 2007-09-24 12:52:33.000000000 +0200
+++ net-2.6/drivers/net/bonding/bond_main.c 2007-09-24 12:57:33.411459811 +0200
@@ -1224,7 +1224,8 @@ static int bond_compute_features(struct
struct slave *slave;
struct net_device *bond_dev = bond->dev;
unsigned long features = bond_dev->features;
- unsigned short max_hard_header_len = ETH_HLEN;
+ unsigned short max_hard_header_len = max((u16)ETH_HLEN,
+ bond_dev->hard_header_len);
int i;
features &= ~(NETIF_F_ALL_CSUM | BOND_VLAN_FEATURES);
Index: net-2.6/drivers/net/bonding/bond_sysfs.c
===================================================================
--- net-2.6.orig/drivers/net/bonding/bond_sysfs.c 2007-09-24 12:55:09.000000000 +0200
+++ net-2.6/drivers/net/bonding/bond_sysfs.c 2007-09-24 13:00:23.752680721 +0200
@@ -260,6 +260,7 @@ static ssize_t bonding_store_slaves(stru
char command[IFNAMSIZ + 1] = { 0, };
char *ifname;
int i, res, found, ret = count;
+ u32 original_mtu;
struct slave *slave;
struct net_device *dev = NULL;
struct bonding *bond = to_bond(d);
@@ -325,6 +326,7 @@ static ssize_t bonding_store_slaves(stru
}
/* Set the slave's MTU to match the bond */
+ original_mtu = dev->mtu;
if (dev->mtu != bond->dev->mtu) {
if (dev->change_mtu) {
res = dev->change_mtu(dev,
@@ -339,6 +341,9 @@ static ssize_t bonding_store_slaves(stru
}
rtnl_lock();
res = bond_enslave(bond->dev, dev);
+ bond_for_each_slave(bond, slave, i)
+ if (strnicmp(slave->dev->name, ifname, IFNAMSIZ) == 0)
+ slave->original_mtu = original_mtu;
rtnl_unlock();
if (res) {
ret = res;
@@ -351,6 +356,7 @@ static ssize_t bonding_store_slaves(stru
bond_for_each_slave(bond, slave, i)
if (strnicmp(slave->dev->name, ifname, IFNAMSIZ) == 0) {
dev = slave->dev;
+ original_mtu = slave->original_mtu;
break;
}
if (dev) {
@@ -365,9 +371,9 @@ static ssize_t bonding_store_slaves(stru
}
/* set the slave MTU to the default */
if (dev->change_mtu) {
- dev->change_mtu(dev, 1500);
+ dev->change_mtu(dev, original_mtu);
} else {
- dev->mtu = 1500;
+ dev->mtu = original_mtu;
}
}
else {
Index: net-2.6/drivers/net/bonding/bonding.h
===================================================================
--- net-2.6.orig/drivers/net/bonding/bonding.h 2007-09-24 12:55:09.000000000 +0200
+++ net-2.6/drivers/net/bonding/bonding.h 2007-09-24 12:57:33.412459636 +0200
@@ -156,6 +156,7 @@ struct slave {
s8 link; /* one of BOND_LINK_XXXX */
s8 state; /* one of BOND_STATE_XXXX */
u32 original_flags;
+ u32 original_mtu;
u32 link_failure_count;
u16 speed;
u8 duplex;
next prev parent reply other threads:[~2007-09-24 15:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 15:27 [PATCH V6 0/9] net/bonding: ADD IPoIB support for the bonding driver Moni Shoua
2007-09-24 15:29 ` [ofa-general] [PATCH V6 1/9] IB/ipoib: Bound the net device to the ipoib_neigh structue Moni Shoua
2007-09-24 15:30 ` [ofa-general] [PATCH V6 2/9] IB/ipoib: Verify address handle validity on send Moni Shoua
2007-09-24 15:32 ` [ofa-general] [PATCH V6 3/9] net/bonding: Enable bonding to enslave non ARPHRD_ETHER Moni Shoua
2007-09-24 15:36 ` [ofa-general] [PATCH V6 4/9] net/bonding: Enable bonding to enslave netdevices not supporting set_mac_address() Moni Shoua
2007-09-24 15:37 ` [ofa-general] [PATCH V6 5/9] net/bonding: Enable IP multicast for bonding IPoIB devices Moni Shoua
2007-09-24 16:04 ` Stephen Hemminger
2007-09-25 9:13 ` Moni Shoua
2007-09-24 15:40 ` Moni Shoua [this message]
2007-09-24 15:46 ` [ofa-general] PATCH V6 7/9] net/bonding: Delay sending of gratuitous ARP to avoid failure Moni Shoua
2007-09-24 15:47 ` [PATCH V6 8/9] net/bonding: Destroy bonding master when last slave is gone Moni Shoua
2007-09-24 15:49 ` [PATCH 9/9] bonding: Optionally allow ethernet slaves to keep own MAC Moni Shoua
2007-09-25 11:01 ` [ofa-general] [PATCH V6 0/9] net/bonding: ADD IPoIB support for the bonding driver Moni Shoua
2007-09-25 15:24 ` Jay Vosburgh
2007-09-25 15:39 ` [ofa-general] " Roland Dreier
2007-10-02 15:49 ` Moni Shoua
2007-10-02 16:52 ` Jeff Garzik
2007-10-02 18:10 ` Jay Vosburgh
2007-10-09 7:24 ` Moni Shoua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F7DA89.1050403@gmail.com \
--to=monisonlists@gmail.com \
--cc=fubar@us.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).