From: John Heffner <jheffner@psc.edu>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [RFC] Make TCP prequeue configurable
Date: Thu, 27 Sep 2007 22:26:02 -0400 [thread overview]
Message-ID: <46FC663A.6030601@psc.edu> (raw)
In-Reply-To: <20070927154432.6ca3b525@freepuppy.rosehill>
Stephen Hemminger wrote:
> On Fri, 28 Sep 2007 00:08:33 +0200
> Eric Dumazet <dada1@cosmosbay.com> wrote:
>
>> Hi all
>>
>> I am sure some of you are going to tell me that prequeue is not
>> all black :)
>>
>> Thank you
>>
>> [RFC] Make TCP prequeue configurable
>>
>> The TCP prequeue thing is based on old facts, and has drawbacks.
>>
>> 1) It adds 48 bytes per 'struct tcp_sock'
>> 2) It adds some ugly code in hot paths
>> 3) It has a small hit ratio on typical servers using many sockets
>> 4) It may have a high hit ratio on UP machines running one process,
>> where the prequeue adds litle gain. (In fact, letting the user
>> doing the copy after being woke up is better for cache reuse)
>> 5) Doing a copy to user in softirq handler is not good, because of
>> potential page faults :(
>> 6) Maybe the NET_DMA thing is the only thing that might need prequeue.
>>
>> This patch introduces a CONFIG_TCP_PREQUEUE, automatically selected if
>> CONFIG_NET_DMA is on.
>>
>> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>>
>
> Rather than having a two more compile cases and test cases to deal
> with. If you can prove it is useless, make a case for killing
> it completely.
I think it really does help in case (4) with old NICs that don't do rx
checksumming. I'm not sure how many people really care about this
anymore, but probably some...?
OTOH, it would be nice to get rid of sysctl_tcp_low_latency.
-John
next prev parent reply other threads:[~2007-09-28 2:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 22:08 [RFC] Make TCP prequeue configurable Eric Dumazet
2007-09-27 22:44 ` Stephen Hemminger
2007-09-28 2:26 ` John Heffner [this message]
2007-09-28 22:40 ` David Miller
2007-10-01 12:24 ` Andi Kleen
2007-09-27 23:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FC663A.6030601@psc.edu \
--to=jheffner@psc.edu \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).