* [PATCH] uapi: fix linux/rds.h userspace compilation errors
@ 2017-02-23 1:13 Dmitry V. Levin
2017-02-23 1:40 ` Santosh Shilimkar
2017-02-23 11:20 ` Sergei Shtylyov
0 siblings, 2 replies; 7+ messages in thread
From: Dmitry V. Levin @ 2017-02-23 1:13 UTC (permalink / raw)
To: David S. Miller, Santosh Shilimkar, Sowmini Varadhan; +Cc: netdev, linux-kernel
Consistently use types from linux/types.h to fix the following
linux/rds.h userspace compilation errors:
/usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
u8 rx_traces;
/usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
/usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
u8 rx_traces;
/usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
/usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
Fixes: 3289025a("RDS: add receive message trace used by application")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
include/uapi/linux/rds.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
index 47c03ca..198892b 100644
--- a/include/uapi/linux/rds.h
+++ b/include/uapi/linux/rds.h
@@ -195,14 +195,14 @@ enum rds_message_rxpath_latency {
};
struct rds_rx_trace_so {
- u8 rx_traces;
- u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
+ __u8 rx_traces;
+ __u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
};
struct rds_cmsg_rx_trace {
- u8 rx_traces;
- u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
- u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
+ __u8 rx_traces;
+ __u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
+ __u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
};
/*
--
ldv
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors
2017-02-23 1:13 [PATCH] uapi: fix linux/rds.h userspace compilation errors Dmitry V. Levin
@ 2017-02-23 1:40 ` Santosh Shilimkar
2017-02-23 11:20 ` Sergei Shtylyov
1 sibling, 0 replies; 7+ messages in thread
From: Santosh Shilimkar @ 2017-02-23 1:40 UTC (permalink / raw)
To: Dmitry V. Levin, David S. Miller, Sowmini Varadhan; +Cc: netdev, linux-kernel
On 2/22/2017 5:13 PM, Dmitry V. Levin wrote:
> Consistently use types from linux/types.h to fix the following
> linux/rds.h userspace compilation errors:
>
> /usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
> u8 rx_traces;
> /usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
> u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
> u8 rx_traces;
> /usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
> u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
> u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
>
> Fixes: 3289025a("RDS: add receive message trace used by application")
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
This was part of the patch I submitted other-day with
rest of the clean-up. Thanks Dmitry.
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors
2017-02-23 1:13 [PATCH] uapi: fix linux/rds.h userspace compilation errors Dmitry V. Levin
2017-02-23 1:40 ` Santosh Shilimkar
@ 2017-02-23 11:20 ` Sergei Shtylyov
2017-02-23 11:35 ` [PATCH v2] " Dmitry V. Levin
1 sibling, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2017-02-23 11:20 UTC (permalink / raw)
To: Dmitry V. Levin, David S. Miller, Santosh Shilimkar,
Sowmini Varadhan
Cc: netdev, linux-kernel
Hello!
On 2/23/2017 4:13 AM, Dmitry V. Levin wrote:
> Consistently use types from linux/types.h to fix the following
> linux/rds.h userspace compilation errors:
>
> /usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
> u8 rx_traces;
> /usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
> u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
> u8 rx_traces;
> /usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
> u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
> u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
>
> Fixes: 3289025a("RDS: add receive message trace used by application")
Need at least 12 hex digits and a space before (.
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2] uapi: fix linux/rds.h userspace compilation errors
2017-02-23 11:20 ` Sergei Shtylyov
@ 2017-02-23 11:35 ` Dmitry V. Levin
2017-02-23 15:55 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Dmitry V. Levin @ 2017-02-23 11:35 UTC (permalink / raw)
To: David S. Miller, Santosh Shilimkar, Sowmini Varadhan,
Sergei Shtylyov
Cc: netdev, linux-kernel
Consistently use types from linux/types.h to fix the following
linux/rds.h userspace compilation errors:
/usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
u8 rx_traces;
/usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
/usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
u8 rx_traces;
/usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
/usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
Fixes: 3289025aedc0 ("RDS: add receive message trace used by application")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
---
v2: fixed "Fixes:" line
include/uapi/linux/rds.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
index 47c03ca..198892b 100644
--- a/include/uapi/linux/rds.h
+++ b/include/uapi/linux/rds.h
@@ -195,14 +195,14 @@ enum rds_message_rxpath_latency {
};
struct rds_rx_trace_so {
- u8 rx_traces;
- u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
+ __u8 rx_traces;
+ __u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
};
struct rds_cmsg_rx_trace {
- u8 rx_traces;
- u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
- u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
+ __u8 rx_traces;
+ __u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
+ __u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
};
/*
--
ldv
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] uapi: fix linux/rds.h userspace compilation errors
2017-02-23 11:35 ` [PATCH v2] " Dmitry V. Levin
@ 2017-02-23 15:55 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2017-02-23 15:55 UTC (permalink / raw)
To: ldv
Cc: santosh.shilimkar, sowmini.varadhan, sergei.shtylyov, netdev,
linux-kernel
From: "Dmitry V. Levin" <ldv@altlinux.org>
Date: Thu, 23 Feb 2017 14:35:23 +0300
> Consistently use types from linux/types.h to fix the following
> linux/rds.h userspace compilation errors:
>
> /usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
> u8 rx_traces;
> /usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
> u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
> u8 rx_traces;
> /usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
> u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
> u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
>
> Fixes: 3289025aedc0 ("RDS: add receive message trace used by application")
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> ---
> v2: fixed "Fixes:" line
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <65dc4fe6-5363-3456-994e-166cb77a90cd@oracle.com>]
* [PATCH] uapi: Fix linux/rds.h userspace compilation errors.
[not found] <65dc4fe6-5363-3456-994e-166cb77a90cd@oracle.com>
@ 2018-09-01 21:20 ` Vinson Lee
2018-09-02 23:15 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Vinson Lee @ 2018-09-01 21:20 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Include linux/in6.h for struct in6_addr.
/usr/include/linux/rds.h:156:18: error: field ‘laddr’ has incomplete type
struct in6_addr laddr;
^~~~~
/usr/include/linux/rds.h:157:18: error: field ‘faddr’ has incomplete type
struct in6_addr faddr;
^~~~~
/usr/include/linux/rds.h:178:18: error: field ‘laddr’ has incomplete type
struct in6_addr laddr;
^~~~~
/usr/include/linux/rds.h:179:18: error: field ‘faddr’ has incomplete type
struct in6_addr faddr;
^~~~~
/usr/include/linux/rds.h:198:18: error: field ‘bound_addr’ has incomplete type
struct in6_addr bound_addr;
^~~~~~~~~~
/usr/include/linux/rds.h:199:18: error: field ‘connected_addr’ has incomplete type
struct in6_addr connected_addr;
^~~~~~~~~~~~~~
/usr/include/linux/rds.h:219:18: error: field ‘local_addr’ has incomplete type
struct in6_addr local_addr;
^~~~~~~~~~
/usr/include/linux/rds.h:221:18: error: field ‘peer_addr’ has incomplete type
struct in6_addr peer_addr;
^~~~~~~~~
/usr/include/linux/rds.h:245:18: error: field ‘src_addr’ has incomplete type
struct in6_addr src_addr;
^~~~~~~~
/usr/include/linux/rds.h:246:18: error: field ‘dst_addr’ has incomplete type
struct in6_addr dst_addr;
^~~~~~~~
Fixes: b7ff8b1036f0 ("rds: Extend RDS API for IPv6 support")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
---
include/uapi/linux/rds.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
index dc520e1a4123..8b73cb603c5f 100644
--- a/include/uapi/linux/rds.h
+++ b/include/uapi/linux/rds.h
@@ -37,6 +37,7 @@
#include <linux/types.h>
#include <linux/socket.h> /* For __kernel_sockaddr_storage. */
+#include <linux/in6.h> /* For struct in6_addr. */
#define RDS_IB_ABI_VERSION 0x301
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] uapi: Fix linux/rds.h userspace compilation errors.
2018-09-01 21:20 ` [PATCH] uapi: Fix " Vinson Lee
@ 2018-09-02 23:15 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2018-09-02 23:15 UTC (permalink / raw)
To: vlee; +Cc: netdev
From: Vinson Lee <vlee@freedesktop.org>
Date: Sat, 1 Sep 2018 21:20:27 +0000
> Include linux/in6.h for struct in6_addr.
...
> Fixes: b7ff8b1036f0 ("rds: Extend RDS API for IPv6 support")
> Signed-off-by: Vinson Lee <vlee@freedesktop.org>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-09-03 3:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-23 1:13 [PATCH] uapi: fix linux/rds.h userspace compilation errors Dmitry V. Levin
2017-02-23 1:40 ` Santosh Shilimkar
2017-02-23 11:20 ` Sergei Shtylyov
2017-02-23 11:35 ` [PATCH v2] " Dmitry V. Levin
2017-02-23 15:55 ` David Miller
[not found] <65dc4fe6-5363-3456-994e-166cb77a90cd@oracle.com>
2018-09-01 21:20 ` [PATCH] uapi: Fix " Vinson Lee
2018-09-02 23:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).