Re: [PATCH net-next v2 6/9] net: ethernet: oa_tc6: Hardware timestamp support for OA TC6 framework

[Andrew Lunn <andrew@lunn.ch>]

On Mon, May 11, 2026 at 06:19:31PM +0000, Selvamani Rajagopal wrote:
> Added hardware timestamp support as defined in Open Alliance
> 10BASET1x MACPHY_Serial_Interface specification. ioctl interface
> added for ethtool to report and set the hardware timestamp feature

7.8 Frame Timestamp Capture

The MAC-PHY may optionally support the capturing of timestamps on
Ethernet frames received from and transmitted to the network. Support
for this option is indicated by the Frame Timestamp Capability (FTSC)
bit in the STDCAP register

I don't see anything in this patch looking for FTSC.

> +/**
> + * oa_tc6_hwtstamp_ioctl - ioctl interface for hardware timestamp
> + * @tc6: oa_tc6 struct.
> + * @rq: request from socket interface
> + * @cmd: value to set/get timestamp configuration
> + *
> + * Return: 0 on success otherwise failed.
> + */
> +int oa_tc6_hwtstamp_ioctl(struct oa_tc6 *tc6, struct ifreq *rq, int cmd)
> +{

It would be better to add a generic ioctl handler. It can call
phy_do_ioctl_running(), and can check if time stamping is support in
the hardware, and if so, also support the time stamping IOCTL calls.

    Andrew