From: Dan Carpenter <dan.carpenter@linaro.org>
To: Yevgeny Kliteynik <kliteyn@nvidia.com>
Cc: Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Muhammad Sammar <muhammads@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] net/mlx5: DR, prevent potential error pointer dereference
Date: Tue, 3 Dec 2024 12:49:00 +0300 [thread overview]
Message-ID: <46a97b8a-042c-4903-817f-efe3be5afabc@stanley.mountain> (raw)
In-Reply-To: <4183c48a-3c78-47e2-a7b2-11d387b6f833@nvidia.com>
On Tue, Dec 03, 2024 at 11:44:12AM +0200, Yevgeny Kliteynik wrote:
> On 03-Dec-24 11:39, Dan Carpenter wrote:
> > On Tue, Dec 03, 2024 at 10:32:13AM +0100, Mateusz Polchlopek wrote:
> > >
> > >
> > > On 11/30/2024 11:01 AM, Dan Carpenter wrote:
> > > > The dr_domain_add_vport_cap() function genereally returns NULL on error
> > >
> > > Typo. Should be "generally"
> > >
> >
> > Sure.
> >
> > > > but sometimes we want it to return ERR_PTR(-EBUSY) so the caller can
> > > > retry. The problem here is that "ret" can be either -EBUSY or -ENOMEM
> > >
> > > Please remove unnecessary space.
> > >
> >
> > What are you talking about?
>
> Oh, I see it :)
> Double space between "retry." and "The"
I'm old. I'm still using fixed width fonts in my editor so I still use
the old school rules.
regards,
dan carpenter
next prev parent reply other threads:[~2024-12-03 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 10:01 [PATCH net] net/mlx5: DR, prevent potential error pointer dereference Dan Carpenter
2024-12-03 0:25 ` Yevgeny Kliteynik
2024-12-03 9:32 ` Mateusz Polchlopek
2024-12-03 9:39 ` Dan Carpenter
2024-12-03 9:44 ` Yevgeny Kliteynik
2024-12-03 9:49 ` Dan Carpenter [this message]
2024-12-03 10:02 ` Mateusz Polchlopek
2024-12-05 8:32 ` Leon Romanovsky
2024-12-05 8:53 ` Mateusz Polchlopek
2024-12-05 9:02 ` Kalesh Anakkur Purayil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a97b8a-042c-4903-817f-efe3be5afabc@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mateusz.polchlopek@intel.com \
--cc=muhammads@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox