From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Kosina <jikos@kernel.org>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe
Date: Tue, 01 Oct 2019 11:46:17 +0200 [thread overview]
Message-ID: <46cce48de455acf073ad0582565d1fe34253f823.camel@sipsolutions.net> (raw)
In-Reply-To: <nycvar.YFH.7.76.1909111238470.473@cbobk.fhfr.pm>
Hi Jiri,
Sorry for the long delay.
> CPU: 1 PID: 28401 Comm: kworker/u8:2 Tainted: G W 5.3.0-rc8 #3
> Hardware name: LENOVO 20K5S22R00/20K5S22R00, BIOS R0IET38W (1.16 ) 05/31/2017
> Workqueue: phy0 ieee80211_beacon_connection_loss_work [mac80211]
> Call Trace:
> dump_stack+0x78/0xb3
> mark_lock+0x28a/0x2a0
> __lock_acquire+0x568/0x1020
> ? iwl_mvm_set_tx_cmd+0x1c5/0x400 [iwlmvm]
> lock_acquire+0xbd/0x1e0
> ? iwl_mvm_tx_mpdu+0xae/0x600 [iwlmvm]
> _raw_spin_lock+0x35/0x50
> ? iwl_mvm_tx_mpdu+0xae/0x600 [iwlmvm]
> iwl_mvm_tx_mpdu+0xae/0x600 [iwlmvm]
> ? ieee80211_tx_h_select_key+0xf1/0x4a0 [mac80211]
> iwl_mvm_tx_skb+0x1f8/0x460 [iwlmvm]
> iwl_mvm_mac_itxq_xmit+0xcc/0x200 [iwlmvm]
> ? iwl_mvm_mac_itxq_xmit+0x55/0x200 [iwlmvm]
> _ieee80211_wake_txqs+0x2cf/0x660 [mac80211]
> ? _ieee80211_wake_txqs+0x5/0x660 [mac80211]
> ? __ieee80211_wake_queue+0x219/0x340 [mac80211]
> ieee80211_wake_queues_by_reason+0x64/0xa0 [mac80211]
>
I'm a bit confused by this.
ieee80211_wake_queues_by_reason() does
spin_lock_irqsave()/spin_unlock_irqrestore() - why is that "{SOFTIRQ-ON-
W} usage"?
Or what did you snip?
johannes
next prev parent reply other threads:[~2019-10-01 9:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 11:03 [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe Jiri Kosina
2019-04-15 11:10 ` Johannes Berg
2019-04-15 11:33 ` Jiri Kosina
2019-04-15 11:37 ` Johannes Berg
2019-04-15 12:06 ` Jiri Kosina
2019-04-15 12:08 ` Johannes Berg
2019-09-11 11:42 ` Jiri Kosina
2019-09-11 12:04 ` Jiri Kosina
2019-09-20 21:34 ` Jiri Kosina
2019-10-01 9:46 ` Johannes Berg [this message]
2019-10-01 9:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46cce48de455acf073ad0582565d1fe34253f823.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=jikos@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox