From: Jens Axboe <axboe@kernel.dk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: io-uring@vger.kernel.org, Haiyue Wang <haiyuewa@163.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
David Wei <dw@davidwei.uk>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] selftests: iou-zcrx: Get the page size at runtime
Date: Thu, 24 Apr 2025 17:34:00 -0600 [thread overview]
Message-ID: <46deb974-5e60-477e-8f0c-9eb358369d73@kernel.dk> (raw)
In-Reply-To: <20250424162923.3a0bdfc4@kernel.org>
On 4/24/25 5:29 PM, Jakub Kicinski wrote:
> On Thu, 24 Apr 2025 17:09:28 -0600 Jens Axboe wrote:
>> On Sat, 19 Apr 2025 22:10:15 +0800, Haiyue Wang wrote:
>>> Use the API `sysconf()` to query page size at runtime, instead of using
>>> hard code number 4096.
>>>
>>> And use `posix_memalign` to allocate the page size aligned momory.
>>>
>>>
>>
>> Applied, thanks!
>>
>> [1/1] selftests: iou-zcrx: Get the page size at runtime
>> commit: 6f4cc653bf408ad0cc203c6ab3088b11f5da11df
>
> Why are you applying this, Jens?
Nobody else had picked it up so far, and I already did the equivalent
one on the liburing side.
>
> tools/testing/selftests/drivers/net/hw/iou-zcrx.c
> ^^^^^^^^^^^
>
> This is a test which runs in netdev infra, and which we asked for.
> It was incorrectly initially routed via io-uring trees and then
> we had to deal with the breakage during the merge window because
> net/lib has diverged.
Come on, it was a one line conflict due to another added test, the
simplest of all conflicts. If that's "breakage" worth mentioning,
well...
> Please revert.
Sure, I can drop it. Doesn't matter to me, as long as gets merged.
--
Jens Axboe
next prev parent reply other threads:[~2025-04-24 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 14:10 [PATCH v1] selftests: iou-zcrx: Get the page size at runtime Haiyue Wang
2025-04-24 13:55 ` Simon Horman
2025-04-24 18:09 ` David Wei
2025-04-24 23:06 ` David Wei
2025-04-24 23:09 ` Jens Axboe
2025-04-24 23:29 ` Jakub Kicinski
2025-04-24 23:34 ` Jens Axboe [this message]
2025-04-24 23:58 ` Jakub Kicinski
2025-04-25 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46deb974-5e60-477e-8f0c-9eb358369d73@kernel.dk \
--to=axboe@kernel.dk \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=haiyuewa@163.com \
--cc=io-uring@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).