netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
	<intel-wired-lan@lists.osuosl.org>,
	<aleksander.lobakin@intel.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v11 09/14] libeth: move idpf_rx_csum_decoded and idpf_rx_extracted
Date: Fri, 18 Oct 2024 15:31:37 -0700	[thread overview]
Message-ID: <46e34729-cf28-4c62-bc72-02cf68c4d43a@intel.com> (raw)
In-Reply-To: <20241013154415.20262-10-mateusz.polchlopek@intel.com>



On 10/13/2024 8:44 AM, Mateusz Polchlopek wrote:
> Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
> idpf and iavf Intel drivers. Change the prefix from idpf_* to libeth_*
> and move mentioned structs to libeth's rx.h header file.
> 
> Adjust usage in idpf driver.
> 
> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> ---

This fails to compile:

> drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c: In function ‘idpf_rx_singleq_clean’:
> drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c:1040:78: error: expected ‘;’ before ‘napi_gro_receive’
>  1040 |                 idpf_rx_singleq_process_skb_fields(rx_q, skb, rx_desc, ptype)
>       |                                                                              ^
>       |                                                                              ;
> ......
>  1043 |                 napi_gro_receive(rx_q->pp->p.napi, skb);
>       |                 ~~~~~~~~~~~~~~~~

Thanks,
Jake

  parent reply	other threads:[~2024-10-18 22:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-13 15:44 [Intel-wired-lan] [PATCH iwl-next v11 00/14] Add support for Rx timestamping for both ice and iavf drivers Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 01/14] virtchnl: add support for enabling PTP on iAVF Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 02/14] ice: support Rx timestamp on flex descriptor Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 03/14] virtchnl: add enumeration for the rxdid format Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 04/14] iavf: add support for negotiating flexible RXDID format Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 05/14] iavf: negotiate PTP capabilities Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 06/14] iavf: add initial framework for registering PTP clock Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 07/14] iavf: add support for indirect access to PHC time Mateusz Polchlopek
2024-10-15 13:56   ` Vadim Fedorenko
2024-10-15 19:24     ` Keller, Jacob E
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 08/14] iavf: periodically cache " Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 09/14] libeth: move idpf_rx_csum_decoded and idpf_rx_extracted Mateusz Polchlopek
2024-10-15 16:41   ` kernel test robot
2024-10-15 18:03   ` kernel test robot
2024-10-18 22:31   ` Jacob Keller [this message]
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 10/14] iavf: define Rx descriptors as qwords Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 11/14] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 12/14] iavf: Implement checking DD desc field Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 13/14] iavf: handle set and get timestamps ops Mateusz Polchlopek
2024-10-13 15:44 ` [Intel-wired-lan] [PATCH iwl-next v11 14/14] iavf: add support for Rx timestamps to hotpath Mateusz Polchlopek
2024-10-18 22:34 ` [Intel-wired-lan] [PATCH iwl-next v11 00/14] Add support for Rx timestamping for both ice and iavf drivers Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46e34729-cf28-4c62-bc72-02cf68c4d43a@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=mateusz.polchlopek@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).