From: Serhey Popovych <serhe.popovych@gmail.com>
To: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next v2 2/6] ipaddress: Simplify print_linkinfo_brief() and it's usage
Date: Thu, 1 Feb 2018 13:00:15 +0200 [thread overview]
Message-ID: <46fe050c-5af3-5e17-abcc-f5e651ad6c9f@gmail.com> (raw)
In-Reply-To: <4601967d-fc05-1d33-55c0-f36a24a2753d@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1200 bytes --]
David Ahern wrote:
> On 1/30/18 11:09 AM, Serhey Popovych wrote:
>> Improve print_linkinfo_brief() and it's callers:
>>
>> 1) Get rid of custom @struct filter pointer @pfilter: it is NULL in
>> all callers anyway and global @filter is used.
>>
>
> Looks like I somehow dropped a vrf change that was going to use that.
> Send a standalone patch to revert 63891c70137f (straight revert does not
> work so some fixup is needed) and then a follow on for the second part
> of this change.
Accepted, will send revert of described commit separately and then
rebase whole series on top of it.
>
>> 2) Simplify calling code in ipaddr_list_flush_or_save() by
>> introducing intermediate variable of @struct nlmsghdr, drop
>> duplicated code: print_linkinfo_brief() never returns values other
>> than <= 0 so we can move print_selected_addrinfo() outside of each
>> block.
>>
>> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
>> ---
>> ip/ip_common.h | 3 +--
>> ip/ipaddress.c | 60 ++++++++++++++++++++++++--------------------------------
>> ip/iplink.c | 2 +-
>> 3 files changed, 28 insertions(+), 37 deletions(-)
>>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2018-02-01 11:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 18:09 [PATCH iproute2-next v2 0/6] ipaddress: Get rid of print_linkinfo_brief() Serhey Popovych
2018-01-30 18:09 ` [PATCH iproute2-next v2 1/6] ipaddress: Improve print_linkinfo() Serhey Popovych
2018-02-01 3:29 ` David Ahern
2018-02-01 10:59 ` Serhey Popovych
2018-01-30 18:09 ` [PATCH iproute2-next v2 2/6] ipaddress: Simplify print_linkinfo_brief() and it's usage Serhey Popovych
2018-02-01 3:43 ` David Ahern
2018-02-01 11:00 ` Serhey Popovych [this message]
2018-01-30 18:09 ` [PATCH iproute2-next v2 3/6] lib: Correct object file dependencies Serhey Popovych
2018-01-30 18:09 ` [PATCH iproute2-next v2 4/6] utils: Introduce and use get_ifname_rta() Serhey Popovych
2018-02-01 3:45 ` David Ahern
2018-01-30 18:09 ` [PATCH iproute2-next v2 5/6] utils: Introduce and use print_name_and_link() to print name@link Serhey Popovych
2018-02-01 3:50 ` David Ahern
2018-02-01 11:09 ` Serhey Popovych
2018-02-01 15:40 ` David Ahern
2018-01-30 18:09 ` [PATCH iproute2-next v2 6/6] ipaddress: Make print_linkinfo_brief() static Serhey Popovych
2018-02-01 3:53 ` [PATCH iproute2-next v2 0/6] ipaddress: Get rid of print_linkinfo_brief() David Ahern
2018-02-01 11:12 ` Serhey Popovych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46fe050c-5af3-5e17-abcc-f5e651ad6c9f@gmail.com \
--to=serhe.popovych@gmail.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).