From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: Re: [PATCH iproute2-next v2 2/6] ipaddress: Simplify print_linkinfo_brief() and it's usage Date: Thu, 1 Feb 2018 13:00:15 +0200 Message-ID: <46fe050c-5af3-5e17-abcc-f5e651ad6c9f@gmail.com> References: <1517335761-22095-1-git-send-email-serhe.popovych@gmail.com> <1517335761-22095-3-git-send-email-serhe.popovych@gmail.com> <4601967d-fc05-1d33-55c0-f36a24a2753d@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FdB6tzufwAE15enUvvKwWNL2jW257rTir" To: David Ahern , netdev@vger.kernel.org Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:36047 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbeBALAS (ORCPT ); Thu, 1 Feb 2018 06:00:18 -0500 Received: by mail-wr0-f195.google.com with SMTP id y3so8610653wrh.3 for ; Thu, 01 Feb 2018 03:00:18 -0800 (PST) In-Reply-To: <4601967d-fc05-1d33-55c0-f36a24a2753d@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FdB6tzufwAE15enUvvKwWNL2jW257rTir Content-Type: multipart/mixed; boundary="lFQOE09N8er3akPcXUvUKT9IYCgsqo6fU"; protected-headers="v1" From: Serhey Popovych To: David Ahern , netdev@vger.kernel.org Message-ID: <46fe050c-5af3-5e17-abcc-f5e651ad6c9f@gmail.com> Subject: Re: [PATCH iproute2-next v2 2/6] ipaddress: Simplify print_linkinfo_brief() and it's usage References: <1517335761-22095-1-git-send-email-serhe.popovych@gmail.com> <1517335761-22095-3-git-send-email-serhe.popovych@gmail.com> <4601967d-fc05-1d33-55c0-f36a24a2753d@gmail.com> In-Reply-To: <4601967d-fc05-1d33-55c0-f36a24a2753d@gmail.com> --lFQOE09N8er3akPcXUvUKT9IYCgsqo6fU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable David Ahern wrote: > On 1/30/18 11:09 AM, Serhey Popovych wrote: >> Improve print_linkinfo_brief() and it's callers: >> >> 1) Get rid of custom @struct filter pointer @pfilter: it is NULL in >> all callers anyway and global @filter is used. >> >=20 > Looks like I somehow dropped a vrf change that was going to use that. > Send a standalone patch to revert 63891c70137f (straight revert does no= t > work so some fixup is needed) and then a follow on for the second part > of this change. Accepted, will send revert of described commit separately and then rebase whole series on top of it. >=20 >> 2) Simplify calling code in ipaddr_list_flush_or_save() by >> introducing intermediate variable of @struct nlmsghdr, drop >> duplicated code: print_linkinfo_brief() never returns values othe= r >> than <=3D 0 so we can move print_selected_addrinfo() outside of e= ach >> block. >> >> Signed-off-by: Serhey Popovych >> --- >> ip/ip_common.h | 3 +-- >> ip/ipaddress.c | 60 ++++++++++++++++++++++++-----------------------= --------- >> ip/iplink.c | 2 +- >> 3 files changed, 28 insertions(+), 37 deletions(-) >> --lFQOE09N8er3akPcXUvUKT9IYCgsqo6fU-- --FdB6tzufwAE15enUvvKwWNL2jW257rTir Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJacvM/AAoJEBTawMmQ61bBVwAIAKXlXK4ARbEzXRqkiTZeTHBA GVijlNp31ALuchZeuKfolWfJ9Ch917thsKDx2V15tvb7Pigmv/TE+ZscicGk0+Nk 9kcQ7jUcQGYlYMBEwXPDNkmtPS/PEhZebOYKkn7hVzJaA5QUTGPRLNPWRJwOs75v 3Z/ZvhiJ1s2orkH2FG5X/4tVCeoYEmpgv4Gm7VDa1nekQuO/uyjdii7b3O6OBQcD NygMsfmjig1MG2Q4LfAxNy33+oHxlE9R6Z4akJpJV1A6wnDWfT0XKPqmCMZgSFZp 1DBBlaMNTnTvM9DaDHhj47+sqnvzI6cbW6i8pNkt00WfCtDMskTa7cYETgt86/U= =/8Vn -----END PGP SIGNATURE----- --FdB6tzufwAE15enUvvKwWNL2jW257rTir--