From: Jeff Garzik <jgarzik@pobox.com>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] mv643xx_eth: Do not modify struct netdev tx_queue_len
Date: Tue, 02 Oct 2007 12:55:29 -0400 [thread overview]
Message-ID: <47027801.8040903@pobox.com> (raw)
In-Reply-To: <20071001230218.GA27461@xyzzy.farnsworth.org>
Dale Farnsworth wrote:
> From: Dale Farnsworth <dale@farnsworth.org>
>
> This driver erroneously zeros dev->tx_queue_len, since
> mp->tx_ring_size has not yet been initialized. Actually,
> the driver shouldn't modify tx_queue_len at all and should
> leave the value set by alloc_etherdev(), currently 1000.
>
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
> ---
> Jeff, this bug was just reported today, or I would have batched
> it with the one I sent you last week. It's an obvious bugfix,
> so I'm not going to hold it in my queue.
>
> drivers/net/mv643xx_eth.c | 1 -
> 1 file changed, 1 deletion(-)
applied
prev parent reply other threads:[~2007-10-02 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 23:02 [PATCH] mv643xx_eth: Do not modify struct netdev tx_queue_len Dale Farnsworth
2007-10-02 16:55 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47027801.8040903@pobox.com \
--to=jgarzik@pobox.com \
--cc=dale@farnsworth.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).